[ 
https://issues.apache.org/jira/browse/CASSANDRA-18676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746315#comment-17746315
 ] 

Branimir Lambov edited comment on CASSANDRA-18676 at 7/24/23 10:00 AM:
-----------------------------------------------------------------------

The {{expected:<8> but was:<25>}} error was the way that this failure presented 
itself before I changed it to check {{CorruptSSTableException}} to get a better 
error message in CASSANDRA-18397.

Made a pull request with fix, awaiting test results 
[here|https://app.circleci.com/pipelines/github/blambov/cassandra/520/workflows/ee724b80-6bba-4ee6-a98a-2a38ce0828d0].


was (Author: blambov):
The {{expected:<8> but was:<25>}} error was the way that this failure presented 
itself before I changed it to check {{CorruptSSTableException}} to get a better 
error message in CASSANDRA-18397.

Made a pull request with fix, awaiting test results 
[here|https://app.circleci.com/pipelines/github/blambov/cassandra/519/workflows/fe8ba73d-970e-4215-8361-5f3902e67516].

> CorruptedSSTablesCompactionsTest is flaky
> -----------------------------------------
>
>                 Key: CASSANDRA-18676
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18676
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/SSTable, Test/unit
>            Reporter: Branimir Lambov
>            Assignee: Branimir Lambov
>            Priority: Normal
>             Fix For: 5.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> See e.g. [this 
> run|https://app.circleci.com/pipelines/github/blambov/cassandra/510/workflows/fd484f76-b0f0-48c9-8672-d73bdc36b8ec/jobs/13575/tests].
> The test was looked at for CASSANDRA-15879, but it is still failing from time 
> to time. One of the failures appears to be introduced by CASSANDRA-14227 and 
> the others by CASSANDRA-18134. The failures are genuine problems with 
> handling corruption, not just test issues.
> The {{CorruptSSTableException}} paths in {{SSTableIdentityIterator}} should 
> likely also catch {{AssertionError}} and {{IllegalArgumentException}}, and 
> most probably the tombstone verification should be done on the read path.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to