[
https://issues.apache.org/jira/browse/CASSANDRA-18690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17747044#comment-17747044
]
Ekaterina Dimitrova commented on CASSANDRA-18690:
-------------------------------------------------
This is ready to commit but I will wait a bit for [~jlewandowski] as he is
away, ot confirm he did not want to add anything else too.
[~mck] mentioned he has also something related to the in-tree scripts but he is
also away the next few hours.
I will leave the ticket in ready to commit for a few hours. But I did not find
any problem with this issue and I recommend we commit it and clean the current
CI failures as soon as possible. Even if I revert the patch that triggered, we
will have many other failures which that path fixed.
> Fix the way we produce a DTest jar
> ----------------------------------
>
> Key: CASSANDRA-18690
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18690
> Project: Cassandra
> Issue Type: Bug
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 5.x
>
>
> The problem is related to the way we produce a {{{}dtest jar{}}}. That
> repackages all dependencies along with our classes in a single jar. Some of
> the dependencies might have digital signatures, which are extracted into
> {{META-INF}} as say {{*.SF}} files. We need to remove them because they are
> invalid for the uber jar we produce.
> Therefore, there are exclusion in {{zipgroupfileset}} operations, more or
> less like this:
> {noformat}
> <zipgroupfileset dir="${build.lib}" includes="*.jar"
> excludes="META-INF/*.SF"/>
> {noformat}
> However, this is wrong. {{exclude}} attribute denotes jar files we don't want
> to repackage rather than filter on the content of the jar file.
> The issue was discovered and explained by [~jlewandowski] in CASSANDRA-17992
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
