[ 
https://issues.apache.org/jira/browse/CASSANDRA-18265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17747032#comment-17747032
 ] 

Brandon Williams edited comment on CASSANDRA-18265 at 7/25/23 5:21 PM:
-----------------------------------------------------------------------

I suspect these are just a result of timeouts which is why we've only seen them 
in Jenkins, but the test code has gotten too clever for itself and still thinks 
it has a LatencyMetrics object, except it performed a diff which only returns a 
dict, thus having no 'scope' attribute for the assertion message when the 
problem occurs.  I have a patch 
[here|https://github.com/driftx/cassandra-dtest/tree/CASSANDRA-18265] to add 
the scope so we can get a usable error message.

||Branch||CI||
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18265-trunk]|[dtest 
repeat|https://app.circleci.com/pipelines/github/driftx/cassandra/1149/workflows/3daf45db-d3d9-4115-bb70-519642fccb88/jobs/39108]|



was (Author: brandon.williams):
I suspect these are just a result of timeouts which is why we've only seen them 
in Jenkins, but the test code has gotten too clever for itself and still thinks 
it has a LatencyMetrics object, except it performed a diff which only returns a 
dict, thus having no 'scope' attribute for the assertion message when the 
problem occurs.  I have a patch 
[here|https://github.com/driftx/cassandra-dtest/tree/CASSANDRA-18265] to add 
the scope so we can get a usable error message.

||Branch||CI||
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18265-trunk]|[dtest 
repeat]|https://app.circleci.com/pipelines/github/driftx/cassandra/1149/workflows/3daf45db-d3d9-4115-bb70-519642fccb88/jobs/39108|


> dtest.client_request_metrics_test.TestClientRequestMetrics.test_client_request_metrics
>  
> ---------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-18265
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18265
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/dtest/python
>            Reporter: Maxwell Guo
>            Assignee: Brandon Williams
>            Priority: Normal
>             Fix For: 5.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1459/testReport/dtest.client_request_metrics_test/TestClientRequestMetrics/test_client_request_metrics/
> and
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1461/testReport/dtest-offheap.client_request_metrics_test/TestClientRequestMetrics/test_client_request_metrics/
> Error Message
> AttributeError: 'dict' object has no attribute 'scope'
> Stacktrace
> self = <client_request_metrics_test.TestClientRequestMetrics object at 
> 0x7f0f53975460>
>     def test_client_request_metrics(self):
>         # this is written as a single test method in order to reuse the same 
> cluster for all tests
>         # setup_once configures and starts the cluster with all schema and 
> preconditions required by all tests.
>         self.setup_once()
>     
> >       self.write_nominal()
> client_request_metrics_test.py:85: 
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> _ 
> client_request_metrics_test.py:116: in write_nominal
>     global_diff, cl_diff = self.validate_nominal('Write',



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to