[
https://issues.apache.org/jira/browse/CASSANDRA-18690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacek Lewandowski updated CASSANDRA-18690:
------------------------------------------
Description:
The problem is related to how we produce the {{dtest jar}}. That repackages all
dependencies along with our classes in a single jar. Some dependencies might
have digital signatures extracted into {{META-INF}} as, say, {{*.SF}} files. We
need to remove them because they are invalid for the uber-jar we produce.
Therefore, there are exclusions in {{zipgroupfileset}} operations, more or less
like this:
{code:xml}
<zipgroupfileset dir="${build.lib}" includes="*.jar" excludes="META-INF/*.SF"/>
{code}
However, this does not work as expected. The {{exclude}} attribute denotes jar
files we don't want to repackage rather than filter on the content of the jar
file. The new BouncyCastle jars include signatures in SF and DSA files, which
all land in the final {{dtest.jar}} regardless of that filter.
See also
https://stackoverflow.com/questions/35577351/exclude-jar-from-ant-build-using-zipgroupfileset/35593838#35593838
The issue was discovered and explained by [~jlewandowski] in CASSANDRA-17992
was:
The problem is related to how we produce the `dtest jar`. That repackages all
dependencies along with our classes in a single jar. Some dependencies might
have digital signatures extracted into META-INF as, say, `*.SF` files. We need
to remove them because they are invalid for the uber-jar we produce. Therefore,
there are exclusions in zipgroupfileset operations, more or less like this:
{code:xml}
<zipgroupfileset dir="${build.lib}" includes="*.jar" excludes="META-INF/*.SF"/>
{code}
However, this does not work as expected. The `exclude` attribute denotes jar
files we don't want to repackage rather than filter on the content of the jar
file. The new BouncyCastle jars include signatures in SF and DSA files, which
all land in the final `dtest.jar` regardless of that filter.
See also
https://stackoverflow.com/questions/35577351/exclude-jar-from-ant-build-using-zipgroupfileset/35593838#35593838
The issue was discovered and explained by [~jlewandowski] in CASSANDRA-17992
> Fix the way we produce a DTest jar
> ----------------------------------
>
> Key: CASSANDRA-18690
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18690
> Project: Cassandra
> Issue Type: Bug
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 5.0
>
>
> The problem is related to how we produce the {{dtest jar}}. That repackages
> all dependencies along with our classes in a single jar. Some dependencies
> might have digital signatures extracted into {{META-INF}} as, say, {{*.SF}}
> files. We need to remove them because they are invalid for the uber-jar we
> produce. Therefore, there are exclusions in {{zipgroupfileset}} operations,
> more or less like this:
> {code:xml}
> <zipgroupfileset dir="${build.lib}" includes="*.jar"
> excludes="META-INF/*.SF"/>
> {code}
> However, this does not work as expected. The {{exclude}} attribute denotes
> jar files we don't want to repackage rather than filter on the content of the
> jar file. The new BouncyCastle jars include signatures in SF and DSA files,
> which all land in the final {{dtest.jar}} regardless of that filter.
> See also
> https://stackoverflow.com/questions/35577351/exclude-jar-from-ant-build-using-zipgroupfileset/35593838#35593838
> The issue was discovered and explained by [~jlewandowski] in CASSANDRA-17992
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
