[
https://issues.apache.org/jira/browse/CASSANDRA-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17747824#comment-17747824
]
Jacek Lewandowski edited comment on CASSANDRA-17992 at 7/27/23 9:52 AM:
------------------------------------------------------------------------
I debugged the problem and found that while {{FastThreadLocal.removeAll}} is
called, {{FastThreadLocal}} disappears from the class loader (?)
In the of the that particular seed, I've added {{io.netty.util.concurrent}}
package to the set of shared packages for in-jvm dtests so that the class will
be managed by the main class loader rather than isolated class loader - that
was my reasoning at least. That fixed the test for that particular seed on my
local machine. I'll run some tests on CI to verify.
UPDATE: This obviously wasn't a core reason. Although the repeated 500x runs of
this test passed, the change broke other JVM dtests massively
was (Author: jlewandowski):
I debugged the problem and found that while {{FastThreadLocal.removeAll}} is
called, {{FastThreadLocal}} disappears from the class loader (?)
In the of the that particular seed, I've added {{io.netty.util.concurrent}}
package to the set of shared packages for in-jvm dtests so that the class will
be managed by the main class loader rather than isolated class loader - that
was my reasoning at least. That fixed the test for that particular seed on my
local machine. I'll run some tests on CI to verify.
> Upgrade Netty on 5.0
> --------------------
>
> Key: CASSANDRA-17992
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17992
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
> Reporter: Ekaterina Dimitrova
> Assignee: Jacek Lewandowski
> Priority: Low
> Fix For: 5.x
>
> Attachments: important-netty-inter-releases.md,
> netty-release-notes-filtered.md, netty-release-notes.md
>
>
> I haven't been able to identify from the Netty docs which was the lowest
> version where JDK17 was added but we are about 40 versions behind in netty 4
> so I suspect we better update.
> -We need to consider there was an issue with class cast exceptions when
> building with JDK17 with newer versions of netty (the newest available in
> March 2022). For the record, we didn't see those when running CI on JDK8 and
> JDK11. We also need to carefully revise the changes between the netty
> versions. -->- CASSANDRA-18180
> Upgrading will cover also a fix in netty that was discussed in
> [this|https://the-asf.slack.com/archives/CK23JSY2K/p1665567660202989] ASF
> Slack thread.
> CC [~benedict] , [~aleksey]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
