[
https://issues.apache.org/jira/browse/CASSANDRA-18700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17748306#comment-17748306
] Stefan Miklosovic edited comment on CASSANDRA-18700 at 7/28/23 7:39 AM: ------------------------------------------------------------------------ [ci 4.0 j11|https://app.circleci.com/pipelines/github/instaclustr/cassandra/2804/workflows/f012861d-6951-4a59-a4cc-b0da49fbe9a7] [ci 4.0 j8|https://app.circleci.com/pipelines/github/instaclustr/cassandra/2804/workflows/d8a203a5-1804-4d18-b099-c3bf8ee51f26] [ci 4.1 j11|https://app.circleci.com/pipelines/github/instaclustr/cassandra/2808/workflows/fbb8b7fd-b4d5-41ab-9f53-d120e8f2d72f] [ci 4.1 j8|https://app.circleci.com/pipelines/github/instaclustr/cassandra/2808/workflows/3dbc534e-4a64-42c8-b66e-8fda001eeb12] [ci trunk j17|https://app.circleci.com/pipelines/github/driftx/cassandra/1151/workflows/912e61c2-d293-496c-b474-3fad1a35f017] [ci trunk j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1151/workflows/9cd0bdde-d5fb-4543-bacf-c9130a705d03] was (Author: smiklosovic): [ci 4.0 j11|https://app.circleci.com/pipelines/github/instaclustr/cassandra/2804/workflows/f012861d-6951-4a59-a4cc-b0da49fbe9a7] [ci 4.0 j8|https://app.circleci.com/pipelines/github/instaclustr/cassandra/2804/workflows/d8a203a5-1804-4d18-b099-c3bf8ee51f26] [ci 4.1 j11|https://app.circleci.com/pipelines/github/instaclustr/cassandra/2808/workflows/fbb8b7fd-b4d5-41ab-9f53-d120e8f2d72f] [ci 4.1 j8|https://app.circleci.com/pipelines/github/instaclustr/cassandra/2808/workflows/3dbc534e-4a64-42c8-b66e-8fda001eeb12] still running [ci trunk j17|https://app.circleci.com/pipelines/github/driftx/cassandra/1151/workflows/912e61c2-d293-496c-b474-3fad1a35f017] [ci trunk j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1151/workflows/9cd0bdde-d5fb-4543-bacf-c9130a705d03] > Remove AssertJ annotations from the production code > --------------------------------------------------- > > Key: CASSANDRA-18700 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18700 > Project: Cassandra > Issue Type: Bug > Components: Build > Reporter: Stefan Miklosovic > Assignee: Stefan Miklosovic > Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > We are using VisibleForTesting annotation from AssertJ in the production > code. At the same time, we are not shipping assertj library in the tarball. > The way it works is that we depend on assertj with "provided" scope and then > we will not ship the lib. It is possible, because the default RetentionPolicy > for that annotation is CLASS which means that while we compile with the > annotation, it does not need to be there in runtime ... > There is VisibleForTesting annotation from Guava which is used extensively. > Usage of VisibleForTesting from AssertJ was used by mistake as that probably > popped up as the first import to add when doing code completion in IDEA. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
