[ 
https://issues.apache.org/jira/browse/CASSANDRA-18700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Miklosovic updated CASSANDRA-18700:
------------------------------------------
          Fix Version/s: 4.0.12
                         4.1.4
                         5.0
                             (was: 5.x)
                             (was: 4.0.x)
                             (was: 4.1.x)
          Since Version: 4.0.0
    Source Control Link: 
https://github.com/apache/cassandra/commit/a0fdda1976c7de9e250e772ecddf6a7317cb1e37
             Resolution: Fixed
                 Status: Resolved  (was: Ready to Commit)

> Remove AssertJ annotations from the production code
> ---------------------------------------------------
>
>                 Key: CASSANDRA-18700
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18700
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Build
>            Reporter: Stefan Miklosovic
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 4.0.12, 4.1.4, 5.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> We are using VisibleForTesting annotation from AssertJ in the production 
> code. At the same time, we are not shipping assertj library in the tarball. 
> The way it works is that we depend on assertj with "provided" scope and then 
> we will not ship the lib. It is possible, because the default RetentionPolicy 
> for that annotation is CLASS which means that while we compile with the 
> annotation, it does not need to be there in runtime ...
> There is VisibleForTesting annotation from Guava which is used extensively. 
> Usage of VisibleForTesting from AssertJ was used by mistake as that probably 
> popped up as the first import to add when doing code completion in IDEA.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to