[
https://issues.apache.org/jira/browse/CASSANDRA-17161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17748679#comment-17748679
]
Stefan Miklosovic edited comment on CASSANDRA-17161 at 7/28/23 4:25 PM:
------------------------------------------------------------------------
This is little bit more tricky than I was expecting. "diff tests" on yaml
(ConfigCompatabilityTest) were failing and as I was digging deeper I realized
that the tests were not updated for a long time and they are actually broken.
As I was updating them, the tests spotted an incompatiblity, rather interesting
one
This is problematic
{code}
@Replaces(oldName = "compaction_tombstone_warning_threshold", converter =
Converters.IDENTITY, deprecated = true)
public volatile long partition_tombstones_warn_threshold = -1;
{code}
In CASSANDRA-17194 it was changed from in "Integer" to "long" (cc
[~adelapena]). While this change is compatible with what it was before as long
is bigger than Integer, the diff tests were complaining about this and this (1)
seems to be the fix ...
I still need to wrap my head around the tests. It seems few things are not
aligned here ...
(1)
https://github.com/apache/cassandra/blob/6eb7a153dfbf023da7bf5912d8f4a122c48b27d8/src/java/org/apache/cassandra/config/Converters.java#L45
was (Author: smiklosovic):
This is little bit more tricky than I was expecting. "diff tests" on yaml were
failing and as I was digging deeper I realized that the tests were not updated
for a long time and they are actually broken. As I was updating them, the tests
spotted an incompatiblity, rather interesting one
This is problematic
{code}
@Replaces(oldName = "compaction_tombstone_warning_threshold", converter =
Converters.IDENTITY, deprecated = true)
public volatile long partition_tombstones_warn_threshold = -1;
{code}
In CASSANDRA-17194 it was changed from in "Integer" to "long" (cc
[~adelapena]). While this change is compatible with what it was before as long
is bigger than Integer, the diff tests were complaining about this and this (1)
seems to be the fix ...
I still need to wrap my head around the tests. It seems few things are not
aligned here ...
(1)
https://github.com/apache/cassandra/blob/6eb7a153dfbf023da7bf5912d8f4a122c48b27d8/src/java/org/apache/cassandra/config/Converters.java#L45
> Remove commitlog_sync_batch_window_in_ms
> ----------------------------------------
>
> Key: CASSANDRA-17161
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17161
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> commitlog_sync_batch_window_in_ms is deprecated in 4.0 and has to be removed
> in 5.0
> This will require also some work around the in-jvm upgrade tests.
> Currently they do not work if we remove a parameter in a later version.
> Side note: They also don't work if we change the type of the parameter in
> Config class in a newer Cassandra version. If you plan to set it in the tests
> themselves, it won't work. If you change the type but your don't set the
> parameter, no issue so there might be some workaround solution instead of
> working on the dtest framework itself.... TBD
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
