[
https://issues.apache.org/jira/browse/CASSANDRA-17687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17749749#comment-17749749
]
Stefan Miklosovic commented on CASSANDRA-17687:
-----------------------------------------------
+1 on the PR as presented.
[~jlewandowski] good catch. I normally skip gen-asciidoc but this is skipped by
.build/docker/build-artifacts.sh as well.
Unless we fix javadocs and fail the build if they are not generated without
error I do not see a lot of value in keeping them around "broken". If somebody
depends on this project e.g. in Maven project, we are shipping proper sources,
right? So folks just attach sources to the project and they can read the code /
"javadoc" is there. I do not think that somebody is going to browse HTML
Javadoc.
I would just commit the PR and moved this to ML.
> Remove "--frames" option when generating javadoc
> ------------------------------------------------
>
> Key: CASSANDRA-17687
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17687
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
> Reporter: Zili Chen
> Assignee: Zili Chen
> Priority: Normal
> Fix For: 5.x
>
> Attachments: signature.asc
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> JDK17 doesn't support this option and it seems not quite necessary. For
> forward compatibility I propose we can remove this option.
> Related JDK issue: [https://bugs.openjdk.org/browse/JDK-8215599]
> I volunteer to prepare a patch if this is in a good direction.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
