[
https://issues.apache.org/jira/browse/CASSANDRA-18729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751813#comment-17751813
]
Stefan Miklosovic commented on CASSANDRA-18729:
-----------------------------------------------
There are few more wrong things with that pom. In parent-pom-template.xml,
there is this in dependency management section
{code}
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-bom</artifactId>
<version>4.1.96.Final</version>
<type>pom</type>
<scope>provided</scope>
</dependency>
{code}
This is wrong. How BOMs are meant to be used is that they are put into
dependencyManagement, they have type "pom" and their scope has to be "import".
That means that all dependencies in that BOM are inserted into dependency
management of the pom hence one can just use dependencies without versions.
This is the basic usage. The fact that it is "provided" in dependency
management and then it was added into dependencies in cassandra-deps-template
just does not make sense at all.
If we left bom (of "import" scope) there, that means that the netty
dependencies in dependency management do not make sense either because all
these dependencies are already declared in that bom. We would then specified it
in child pom without versions etc ...
I just removed that BOM from dependency management. It is just plain wrong how
it is used there right now.
I will do builds once again.
> Remove unnecessary Netty dependencies after upgrade to 4.1.96
> -------------------------------------------------------------
>
> Key: CASSANDRA-18729
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18729
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> We introduced a lot of unnecessary dependencies in CASSANDRA-17992 which
> should not be there. This ticket is about their removal.
> The original patch also got some dependencies wrong. They are 4.1.94 but we
> are on 4.1.96.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
