[ 
https://issues.apache.org/jira/browse/CASSANDRA-18706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752907#comment-17752907
 ] 

Brandon Williams edited comment on CASSANDRA-18706 at 8/10/23 7:10 PM:
-----------------------------------------------------------------------

I want to note that it doesn't really make sense for this test to assert there 
is only one sstable, as it's not really concerned with that and makes no 
guarantees for it.  That said, I still wanted to know what was happening so I 
added some debugging 
[here|https://github.com/driftx/cassandra/commits/CASSANDRA-18706-trunk] and 
ran circle to failure 
[here|https://app.circleci.com/pipelines/github/driftx/cassandra/1175/workflows/a9634ac0-120c-40d3-b800-0745b2ca8827/jobs/42078/tests].
  Here we find the culprit:

{noformat}
[junit-timeout] INFO  [OptionalTasks:1] 2023-08-10 17:35:42,520 
ColumnFamilyStore.java:1017 - Enqueuing flush of cql_test_keyspace.mv_51, 
Reason: COMMITLOG_DIRTY, Usage: 412B (0%) on-heap, 44B (0%) off-heap
{noformat}

The simplest way to fix this is allow two sstables, which I added on top of the 
improved error message 
[here|https://github.com/driftx/cassandra/commit/019fe3fd7a05061d0365b36df446644b87e5ad68].


was (Author: brandon.williams):
I want to note that it doesn't really make sense for this test to assert there 
is only one sstable, as it's not really concerned with that and make no 
guarantees for it.  That said, I still wanted to know what was happening so I 
added some debugging 
[here|https://github.com/driftx/cassandra/commits/CASSANDRA-18706-trunk] and 
ran circle to failure 
[here|https://app.circleci.com/pipelines/github/driftx/cassandra/1175/workflows/a9634ac0-120c-40d3-b800-0745b2ca8827/jobs/42078/tests].
  Here we find the culprit:

{noformat}
[junit-timeout] INFO  [OptionalTasks:1] 2023-08-10 17:35:42,520 
ColumnFamilyStore.java:1017 - Enqueuing flush of cql_test_keyspace.mv_51, 
Reason: COMMITLOG_DIRTY, Usage: 412B (0%) on-heap, 44B (0%) off-heap
{noformat}

The simplest way to fix this is allow two sstables, which I added on top of the 
improved error message 
[here|https://github.com/driftx/cassandra/commit/019fe3fd7a05061d0365b36df446644b87e5ad68].

> Test failure: 
> org.apache.cassandra.cql3.ViewTest.testIgnoreUpdate-compression.jdk11 (from 
> org.apache.cassandra.cql3.ViewTest-compression.jdk11)
> -----------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-18706
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18706
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: Ekaterina Dimitrova
>            Assignee: Brandon Williams
>            Priority: Normal
>             Fix For: 5.x
>
>
> Seen here - 
> [https://ci-cassandra.apache.org/job/Cassandra-trunk/1650/testReport/junit/org.apache.cassandra.cql3/ViewTest/testIgnoreUpdate_compression_jdk11/]
> h3.  
> {code:java}
> Error Message
> expected:<1> but was:<2>
> Stacktrace
> junit.framework.AssertionFailedError: expected:<1> but was:<2> at 
> org.apache.cassandra.cql3.ViewTest.testIgnoreUpdate(ViewTest.java:328) at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
> Method) at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  at 
> org.jboss.byteman.contrib.bmunit.BMUnitRunner$6.evaluate(BMUnitRunner.java:263)
>  at 
> org.jboss.byteman.contrib.bmunit.BMUnitRunner$1.evaluate(BMUnitRunner.java:97)
> {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to