[
https://issues.apache.org/jira/browse/CASSANDRA-18717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756092#comment-17756092
]
Ekaterina Dimitrova edited comment on CASSANDRA-18717 at 8/18/23 6:21 PM:
--------------------------------------------------------------------------
I just reviewed the 5.0 PR.
Overall looks good to me. (except adding the javadoc check under ant check is
still missing, but this was discussed only yesterday)
But after reviewing the whole patch I am inclined to suggest only big fat
warning on broken task and not to fail builds.
I can imagine how failing will slow down big CEPs as people will see it most
probably in CI when they run `check`. I would prefer follow up tickets. IDE
does not warn you on all potential errors, not sure if we can change that by
default for the project? Some I see as errors, some I don't. More on the PR.
With the current setup this will slow down and annoy people who do big features
development. Open to hear opinions or suggestions how to prevent that from
happening.
was (Author: e.dimitrova):
I just reviewed the 5.0 PR.
Overall looks good to me.
But after reviewing the whole patch I am inclined to suggest only big fat
warning on broken task and not to fail builds.
I can imagine how failing will slow down big CEPs as people will see it most
probably in CI when they run `check`. I would prefer follow up tickets. IDE
does not warn you on all potential errors, not sure if we can change that by
default for the project? Some I see as errors, some I don't. More on the PR.
With the current setup this will slow down and annoy people who do big features
development. Open to hear opinions or suggestions how to prevent that from
happening.
> Fix errors or remove ant javadoc task
> -------------------------------------
>
> Key: CASSANDRA-18717
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18717
> Project: Cassandra
> Issue Type: Bug
> Components: Documentation/Javadoc
> Reporter: Ekaterina Dimitrova
> Assignee: Maxim Muzafarov
> Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> As discussed on CASSANDRA-17687, the javadoc task completes successfully, but
> there are errors that deserve to be fixed if we keep the task around.
> If we do not plan to use it, we should remove it and reduce the clutter.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
