[ 
https://issues.apache.org/jira/browse/CASSANDRA-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097872#comment-13097872
 ] 

Hudson commented on CASSANDRA-3128:
-----------------------------------

Integrated in Cassandra #1077 (See 
[https://builds.apache.org/job/Cassandra/1077/])
    Use only one parameters for compression options
patch by slebresne; reviewed by jbellis for CASSANDRA-3128

slebresne : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165577
Files : 
* /cassandra/trunk/CHANGES.txt
* /cassandra/trunk/NEWS.txt
* /cassandra/trunk/interface/cassandra.thrift
* 
/cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java
* 
/cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/CfDef.java
* /cassandra/trunk/src/avro/internode.genavro
* /cassandra/trunk/src/java/org/apache/cassandra/cli/CliClient.java
* /cassandra/trunk/src/java/org/apache/cassandra/config/CFMetaData.java
* 
/cassandra/trunk/src/java/org/apache/cassandra/io/compress/CompressedSequentialWriter.java
* 
/cassandra/trunk/src/java/org/apache/cassandra/io/compress/CompressionMetadata.java
* 
/cassandra/trunk/src/java/org/apache/cassandra/io/compress/CompressionParameters.java
* /cassandra/trunk/src/java/org/apache/cassandra/io/sstable/SSTableWriter.java
* /cassandra/trunk/src/resources/org/apache/cassandra/cli/CliHelp.yaml
* /cassandra/trunk/tools/stress/src/org/apache/cassandra/stress/Session.java


> Replace compression and compression_options config parameters by just a 
> compression_options map.
> ------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3128
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3128
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 1.0
>
>         Attachments: 0001-Thrift-files.patch, 
> 0002-Use-only-one-options-for-compression.patch
>
>
> As suggested on CASSANDRA-3105, as long as 1.0 is not out, we could replace 
> the 'compression' and 'compression_options' parameters by just one that would 
> allow to write:
> {noformat}
>   compression_options = { sstable_compression: SnappyCompressor, 
> block_length_kb: 32 }
> {noformat}
> This would allow for more future-proof, in particular if we decide to make 
> CASSANDRA-3015 pluggable in the future or for CASSANDRA-3127 as this would 
> allow us to simply evolve to say:
> {noformat}
>   compression_options = { sstable_compression: SnappyCompressor, 
> block_length_kb: 32, stream_compression: LZFCompressor }
> {noformat}
> This has the advantages of (1) not polluting CfDef and (2) leaving the option 
> of documenting some option only in advanced documentation (if said option is 
> not meant for new users)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to