[
https://issues.apache.org/jira/browse/CASSANDRA-18787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761053#comment-17761053
]
Ekaterina Dimitrova commented on CASSANDRA-18787:
-------------------------------------------------
That's a nice improvement.
I left a few questions/comments on the PR.
For completeness:
1) What is the story behind field_size_limit? Why was it needed, and was it a
leftover, or is it a bug that is unused anymore?
2) Why do we remove maybe_ensure_text? From the code comment next to the
method -
{quote}bq. # Make sure some user values read from the command line are in
unicode
{quote}
3) Why do we remove the validation that we do not have a version below 3?
4) It looks like the new set_cql_version does not handle alpha, and beta
versions as the old one.
> Replace obsolete Python functions
> ---------------------------------
>
> Key: CASSANDRA-18787
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18787
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
> Reporter: Brad Schoening
> Assignee: Brad Schoening
> Priority: Low
> Fix For: 5.x
>
>
> # Python's stdlib datetime.timezone.utc can replace the custom UTC timezone
> in pylib/cqlshlib/util.py.
> # Removed unused attributes and functions:
> ## field_size _limit
> ## trim_if_present()
> ## maybe_ensure_text()
> # Simplify cql_version handling into a settor
> Functionality should remain the same while simplifying the code by
> eliminating ~60 lines.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
