[
https://issues.apache.org/jira/browse/CASSANDRA-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761365#comment-17761365
]
Michael Semb Wever commented on CASSANDRA-18756:
------------------------------------------------
Given this feature can only be enabled with both the table option and a system
variable, and it's overly clear the risks (and carefully documented), I would
have no objection to making it work correctly. It can have a dramatic saving
on nodes for its intended use-cases. I leave that call up to you both.
Otherwise, +1 on the patch as it is.
> TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps
> overlaping SSTable references
> ----------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-18756
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18756
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
> Reporter: Branimir Lambov
> Assignee: Ethan Brown
> Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When {{unsafe_aggressive_sstable_expiration}} is turned on, TWCS should not
> create or maintain an iterator of overlapping sstables. However, because
> {{TimeWindowCompactionController}} inherits from {{CompactionController}} and
> only sets {{ignoreOverlaps}} after the base class has constructed the overlap
> iterator, it ends up making an overlap iterator and then never updating it.
> The end result is that such a compaction keeps references to lots of and
> likely _all_ other SSTables on the node and thus delays the deletion of
> obsolete ones by hours or even days.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
