[
https://issues.apache.org/jira/browse/CASSANDRASC-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762521#comment-17762521
]
ASF subversion and git services commented on CASSANDRASC-69:
------------------------------------------------------------
Commit 63292010803875af6496ce7c787f404e66311375 in cassandra-sidecar's branch
refs/heads/trunk from Francisco Guerrero
[ https://gitbox.apache.org/repos/asf?p=cassandra-sidecar.git;h=6329201 ]
CASSANDRASC-69: Refactor Sidecar configuration
This commit refactors the Sidecar configuration. It separates the configuration
objects from the cluster objects. For example, by default `InstancesConfig` will
be provisioned from the configured `InstanceConfiguration`.
POJOs now represent the configuration from the yaml files. Adding new
configurations
entails adding new POJOs and their relationships as well as updating the default
yaml configuration file.
Patch by Francisco Guerrero; Reviewed by Dinesh Joshi, Yifan Cai for
CASSANDRASC-69
> Refactor Configuration
> ----------------------
>
> Key: CASSANDRASC-69
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-69
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
> Reporter: Francisco Guerrero
> Assignee: Francisco Guerrero
> Priority: Normal
> Labels: pull-request-available
>
> Currently, the Sidecar Configuration is provided via a yaml file. The yaml
> file is parsed and a the configuration is used during the Sidecar application
> runtime.
> The configuration parsing is done manually, and adding a new configuration to
> the yaml file has become a big task where multiple files need to be touched.
> Ideally, we should add the configuration POJOs needed for new configurations
> and add the new fields in the yaml file.
> Additionally, we are leaking the configuration implementation to the
> {{InstancesConfig}}. We should improve the separation of concerns from the
> yaml configuration and the instances configuration.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
