[
https://issues.apache.org/jira/browse/CASSANDRA-18322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762758#comment-17762758
]
Stefan Miklosovic commented on CASSANDRA-18322:
-----------------------------------------------
[~blerer] I implemented it here (1) (same PR for trunk)
I like this idea so we avoid instanceof and it is more visible when that method
is on CqlStatement.
Batches are considered unqualified if one of the modification statements is
unqualified (2).
I am not completely sure what is the logic behind that comment / condition in
ExecuteMessage in 4.0+ though.
(1) [https://github.com/apache/cassandra/pull/2668/files]
(2)
[https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/statements/BatchStatement.java#L627-L634]
> Warn about unqualified prepared statement only if it is a select, update,
> delete, insert
> ----------------------------------------------------------------------------------------
>
> Key: CASSANDRA-18322
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18322
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
> Reporter: Mohammad Aburadeh
> Assignee: Stefan Miklosovic
> Priority: Urgent
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x
>
>
> Hi,
> We get the following warnings when we use prepared statements with "create
> keyspace ... " or "drop keyspace" statements.
> "
> {{USE <keyspace>}} with prepared statements is considered to be an
> anti-pattern due to ambiguity in non-qualified table names. Please consider
> removing instances of {{{}Session#setKeyspace(<keyspace>){}}},
> {{Session#execute("USE <keyspace>")}} and {{cluster.newSession(<keyspace>)}}
> from your code, and always use fully qualified table names (e.g.
> <keyspace>.<table>). Keyspace used: null, statement keyspace: null, statement
> id: 8153d922390fdf9a9963bfeda85b2f3b at
> "
> Such statements are already full-qualified. So, why are we getting this
> warning?
> Regards
> Mohammad
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
