yifan-c commented on code in PR #15: URL: https://github.com/apache/cassandra-analytics/pull/15#discussion_r1318917122
########## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/validation/CassandraValidator.java: ########## @@ -0,0 +1,24 @@ +package org.apache.cassandra.spark.validation; + +import org.apache.cassandra.sidecar.client.SidecarClient; +import org.apache.cassandra.sidecar.common.data.HealthResponse; + +public class CassandraValidator implements StartupValidator Review Comment: Add a brief description on what the validator does, and the other new validators too. ########## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/validation/CassandraValidator.java: ########## @@ -0,0 +1,24 @@ +package org.apache.cassandra.spark.validation; Review Comment: Add license header for the new files. ########## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java: ########## @@ -38,6 +38,8 @@ import org.apache.cassandra.spark.data.partitioner.Partitioner; import org.apache.cassandra.spark.utils.CqlUtils; import org.apache.cassandra.spark.utils.ScalaFunctions; +import org.apache.cassandra.spark.validation.SidecarValidator; Review Comment: not used. ########## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/validation/StartupValidatable.java: ########## @@ -0,0 +1,6 @@ +package org.apache.cassandra.spark.validation; + +public interface StartupValidatable Review Comment: Add detailed java docs on interfaces -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
