[ 
https://issues.apache.org/jira/browse/CASSANDRA-18799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763888#comment-17763888
 ] 

Maxim Muzafarov commented on CASSANDRA-18799:
---------------------------------------------

[~e.dimitrova] I checked the changes between 0.5.1 and 0.7.4, and found a few 
breaking changes that could theoretically affect us, but in practice did not 
affect the source code we use.

The breaking changes are:
- (there are no usages of this) If entry TTLs are used, it is required to 
configure the cache with OHCacheBuilder.timeouts(true)
- (we use a cache adapter for OHCache, that is not affected) Signatures of 
OHCache.put() and OHCache.remove() methods have been changed to return a 
boolean value. 

https://github.com/snazy/ohc/blob/develop/CHANGES.txt#L41

Unless I'm missing something, everything looks good and we can safely migrate 
to a new version. The changes have been rebased to the latest trunk. I've 
checked the compilation locally.

Should we re-run the CI from scratch and proceed with further steps?

> Remove org.caffinitas.ohc:ohc-core-j8 dependency
> ------------------------------------------------
>
>                 Key: CASSANDRA-18799
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18799
>             Project: Cassandra
>          Issue Type: Task
>          Components: Dependencies
>            Reporter: Maxim Muzafarov
>            Assignee: Maxim Muzafarov
>            Priority: Normal
>             Fix For: 5.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> It seems the `org.caffinitas.ohc:ohc-core-j8` is not required anymore and the 
> Cassandra project moved away from JDK8 support. The changes are here: 
> CASSANDRA-18255
> We can remove it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to