[ 
https://issues.apache.org/jira/browse/CASSANDRA-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099221#comment-13099221
 ] 

Hudson commented on CASSANDRA-3145:
-----------------------------------

Integrated in Cassandra #1084 (See 
[https://builds.apache.org/job/Cassandra/1084/])
    fix IntervalTree max calculation
patch by Paul Cannon; reviewed by Ben Coverston for CASSANDRA-3145

jbellis : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166302
Files : 
* /cassandra/trunk/CHANGES.txt
* /cassandra/trunk/src/java/org/apache/cassandra/db/ColumnFamilyStore.java
* /cassandra/trunk/src/java/org/apache/cassandra/db/DataTracker.java
* 
/cassandra/trunk/src/java/org/apache/cassandra/utils/IntervalTree/IntervalNode.java
* 
/cassandra/trunk/src/java/org/apache/cassandra/utils/IntervalTree/IntervalTree.java


> IntervalTree could miscalculate its max
> ---------------------------------------
>
>                 Key: CASSANDRA-3145
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3145
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: paul cannon
>            Assignee: paul cannon
>            Priority: Minor
>             Fix For: 1.0
>
>         Attachments: 3145.patch.txt
>
>
> The implementation of IntervalTree in trunk expects an ordered list of 
> Interval objects as the argument to its constructor. It uses the ordering 
> (only) to determine its minimum and maximum endpoints out of all Intervals 
> stored in it. However, no ordering should be able to guarantee the first 
> element has the set-wide minimum and that the last element has the set-wide 
> maximum; you have to order by minima or maxima or some combination.
> I propose that the requirement for ordered input to the IntervalTree 
> constructor be dropped, seeing as how the elements will be sorted as 
> necessary inside the IntervalNode object anyway. The set-wide minimum and 
> maximum could be more straightforwardly calculated inside IntervalNode, and 
> just exposed via IntervalTree.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to