[ https://issues.apache.org/jira/browse/CASSANDRA-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Branimir Lambov updated CASSANDRA-18756: ---------------------------------------- Reviewers: Branimir Lambov, Michael Semb Wever, Branimir Lambov (was: Branimir Lambov, Michael Semb Wever) Branimir Lambov, Michael Semb Wever, Branimir Lambov (was: Branimir Lambov, Michael Semb Wever) Status: Review In Progress (was: Patch Available) > TimeWindowCompactionStrategy with unsafe_aggressive_sstable_expiration keeps > overlaping SSTable references > ---------------------------------------------------------------------------------------------------------- > > Key: CASSANDRA-18756 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18756 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction > Reporter: Branimir Lambov > Assignee: Ethan Brown > Priority: Normal > Time Spent: 0.5h > Remaining Estimate: 0h > > When {{unsafe_aggressive_sstable_expiration}} is turned on, TWCS should not > create or maintain an iterator of overlapping sstables. However, because > {{TimeWindowCompactionController}} inherits from {{CompactionController}} and > only sets {{ignoreOverlaps}} after the base class has constructed the overlap > iterator, it ends up making an overlap iterator and then never updating it. > The end result is that such a compaction keeps references to lots of and > likely _all_ other SSTables on the node and thus delays the deletion of > obsolete ones by hours or even days. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org