[
https://issues.apache.org/jira/browse/CASSANDRA-18816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767673#comment-17767673
]
David Capwell commented on CASSANDRA-18816:
-------------------------------------------
bq. there is also a bunch of TODOs in the patch, should those be fixed or
removed?
{code}
$ git diff trunk | grep TODO
+ throw new UnsupportedOperationException("TODO");
+ throw new UnsupportedOperationException("TODO");
+ throw new UnsupportedOperationException("TODO");
+ throw new UnsupportedOperationException("TODO");
{code}
I can always remove the word "TODO" here, but this is just blocking thread APIs
we don't currently support. I don't intend to add them in this patch as its
not needed.
{code}
+ { PREPARE, VALIDATION } // TODO (coverage): SYNC doesn't have a good entry
point for injecting the failure
{code}
this one I want to think about more, since sync doesn't have a good point to
cause a failure, this condition wasn't checked... ill work on this
All other TODOs are fixed now or removed
> Add support for repair coordinator to retry messages that timeout
> -----------------------------------------------------------------
>
> Key: CASSANDRA-18816
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18816
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Repair
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10h 40m
> Remaining Estimate: 0h
>
> Now that CASSANDRA-15399 is in, most of the repair messages have a state that
> they can check against to make message delivery idempotent, allowing the
> coordinator to retry such messages; a few of the most critical messages to
> retry are: PREPARE_MSG, VALIDATION_REQ, VALIDATION_RSP, SYNC_REQ, and
> SYNC_RSP.
> With this I propose making the coordinator able to retry these key messages
> to try and make repair more resilient to ephemeral issues.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
