[
https://issues.apache.org/jira/browse/CASSANDRA-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769773#comment-17769773
]
Stefan Miklosovic edited comment on CASSANDRA-18742 at 9/27/23 8:09 PM:
------------------------------------------------------------------------
The flaky test is a test method in AlterTest (1).
This patch was modifying AlterTest to be aligned with the proposed changes.
Then, upon build, as our CircleCI scripting makes modified test classes to run
in a loop, that unrelated test method was executed in a loop too. We have
basically discovered a flaky test. We have not modified that test method in
particular.
(1)
https://app.circleci.com/pipelines/github/instaclustr/cassandra/3154/workflows/abf98f42-b2b3-4dfd-ab4b-37bd4c24e102/jobs/118172/tests#failed-test-0
was (Author: smiklosovic):
The flaky test is a test method in AlterTest (1).
This patch was modifying AlterTest to be aligned with the proposed changes.
Then, upon build, as our CircleCI scripting makes modified test classes to run
in a loop, that unrelated test method was executed in a loop too. We have
basically discovered a flaky test. We have not modifying that test method in
particular.
(1)
https://app.circleci.com/pipelines/github/instaclustr/cassandra/3154/workflows/abf98f42-b2b3-4dfd-ab4b-37bd4c24e102/jobs/118172/tests#failed-test-0
> Remove deprecated options in CompressionParams
> ----------------------------------------------
>
> Key: CASSANDRA-18742
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18742
> Project: Cassandra
> Issue Type: Task
> Components: Feature/Compression
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> These should go away (1). They were deprecated like 8 years ago in
> CASSANDRA-9712 and CASSANDRA-9839.
> We should also remove this (2). That is a little bit more tricky but nothing
> special I would say ...
> (1)
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L86-L88
> (2)
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/CompressionParams.java#L96-L97
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
