[
https://issues.apache.org/jira/browse/CASSANDRA-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100089#comment-13100089
]
Jérémy Sevellec commented on CASSANDRA-2961:
--------------------------------------------
ok I like it, it's few things :-) :
- hamscrest : In my case, It's true, I just use hamcrest with "is" into assert.
There is a lot of other verb which interesting to make asserting more readable.
Tt was for help for next but if you want I can remove it. tell me you do you
prefer.
- VersionedValue.getExpireTime : It's true, I put it in the Gossiper? a utility
class?
- addExpireTimeIfFound : ok i put one call in excise but i keep the method to
isolate the thinking. if you're ok.
- DEBUG log : ho there was (to make my test), but i remove it before creating
the patch... I add them again
> Expire dead gossip states based on time
> ---------------------------------------
>
> Key: CASSANDRA-2961
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2961
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 1.0
> Reporter: Brandon Williams
> Priority: Minor
> Fix For: 1.0
>
> Attachments: trunk-2961-v2.patch, trunk-2961.patch
>
>
> Currently dead states are held until aVeryLongTime, 3 days. The problem is
> that if a node reboots within this period, it begins a new 3 days and will
> repopulate the ring with the dead state. While mostly harmless, perpetuating
> the state forever is at least wasting a small amount of bandwidth. Instead,
> we can expire states based on a ttl, which will require that the cluster be
> loosely time synced; within the quarantine period of 60s.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
