[ https://issues.apache.org/jira/browse/CASSANDRA-18665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771251#comment-17771251 ]
Maxim Muzafarov commented on CASSANDRA-18665: --------------------------------------------- [~mck] I'll take a look, I need some time to get into the context considering the fact that tomorrow is a holiday in Germany, so I'll miss at least half of a day ;) Would you be so kind as to create a PR request for these changes, so that my comments will have more meaning? I have briefly checked the changed files. A response would be greatly appreciated. - The solution design assumes that we have in-tree scripts in the Cassandra repository and Jenkins-groovy in the build repo, right? I have just naively thought that it is good to have groovy scripts to be versioned as the in-tree scripts do. As an example, the Kafka project stores the Jenkins file right in [the project's root.|[https://github.com/apache/kafka/blob/trunk/Jenkinsfile].] I can assume that this is for the sake of compatibility, we can build the release branch without having ifs for each release. - {{cassandra_regx_supported_versions="^(2.2|3.0|3.11|4.0|4.1)(.[0-9]+)?$"}} - do we need the {{2.2}} release in the following supported version regexp? I thought that it was out of support. [https://github.com/apache/cassandra-builds/compare/trunk...thelastpickle:cassandra-builds:mck/18665#diff-f458d745bb6227c4f9161c75ffed2a98d0ee3cd7da734afe7e759670c5969b3cR23] - another thing, I think we should use "check.skip" instead of "no-checkstyle" because we've merged them into the single step here CASSANDRA-18618 https://github.com/apache/cassandra-builds/compare/trunk...thelastpickle:cassandra-builds:mck/18665#diff-d2b76f566cc7806c4f4c4e1f5a3fee9e4acc5593565c85426715a8c127a6cb96R248 - should we uncomment this? https://github.com/apache/cassandra/compare/cassandra-5.0...thelastpickle:cassandra:mck/18665#diff-85e9dd252791b6be0f6b996585688ecd843f7c4a640f47b515b44979f426f25bR54 > Update jenkins groovy dsl to use in-tree scripts > ------------------------------------------------ > > Key: CASSANDRA-18665 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18665 > Project: Cassandra > Issue Type: Task > Components: CI > Reporter: Michael Semb Wever > Assignee: Michael Semb Wever > Priority: Normal > Fix For: 5.0.x, 5.x > > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org