[
https://issues.apache.org/jira/browse/CASSANDRA-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771495#comment-17771495
]
Stefan Miklosovic commented on CASSANDRA-14351:
-----------------------------------------------
Improved PR is here (1)
1) it is not "SystemD", it is "systemd"
2) we do not need to have a special api around getting a pid, there is Sigar
for that already so we can reuse it which makes whole solution simpler.
3) various logging improvements and minor refactorings (lowering it all to
debug)
I was thinking that we should also notify when error happens and JVM is about
to get kill vim JVMStabilityInspector, exactly before this (2). But then I
realized that I am not sure why we are exiting with error code 100, that seems
completely arbitrary and we should probably take some time to actually define
what we should exit with and and when. Hence, unless that work is not done, I
think we should go just with a simple notification when a node started.
(1)
https://github.com/apache/cassandra/pull/2764/files#diff-4ec8149ecacb5e0c6945d9f08dfde9efbb46b5291dbc748f32b6a6b1ae6bd0ed
(2)
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/JVMStabilityInspector.java#L267
> Support systemd SD_NOTIFY interface during startup
> --------------------------------------------------
>
> Key: CASSANDRA-14351
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14351
> Project: Cassandra
> Issue Type: Improvement
> Components: Packaging
> Reporter: Thomas Bechtold
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When cassandra is started via systemd, it would be nice to support the
> [SD_NOTIFY|https://www.freedesktop.org/software/systemd/man/sd_notify.html]
> protocol so systemd know, when cassandra is ready (that can be use for
> dependencies or when you need to wait until cassandra startup is done).
> A very simple implementation could be done using the
> {code:java}
> systemd-notify --ready
> {code}
> command line tool (and ignore it if the tool is not there)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
