[ 
https://issues.apache.org/jira/browse/CASSANDRA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772637#comment-17772637
 ] 

Maxim Muzafarov commented on CASSANDRA-18836:
---------------------------------------------

Of course we should, I should have run the tests to see that changing only the 
IndexFileUtils is not enough, was a bit confused by the title :)

Trunk:
[https://github.com/apache/cassandra/pull/2687]

5.0:
[https://github.com/apache/cassandra/pull/2782]

CI for the trunk:
[https://app.circleci.com/pipelines/github/Mmuzaf/cassandra/416/workflows/90f7c963-2d47-40d1-a88d-ef159addb6e0]


As soon as I get the results from CI, I'll check them to make sure that I 
didn't miss anything.

> Replace CRC32 w/ CRC32C in IndexFileUtils.ChecksummingWriter
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-18836
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18836
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Feature/2i Index, Feature/SAI
>            Reporter: Caleb Rackliffe
>            Assignee: Maxim Muzafarov
>            Priority: Normal
>             Fix For: 5.0-alpha2, 5.x
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> It seems that now we're on Java 11 for 5.0, there isn't much reason not to 
> use CRC32C as a drop-in replacement for CRC32. SAI isn't even released, so 
> has no binary compatibility entanglements, and this should be pretty 
> straightforward.
> See https://github.com/apache/bookkeeper/pull/3309



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to