[ https://issues.apache.org/jira/browse/CASSANDRA-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773696#comment-17773696 ]
Branimir Lambov commented on CASSANDRA-18534: --------------------------------------------- bq. Also, do you think it is possible and useful to make sstable_format contain custom parameters? _All_ of the parameters to the SSTable format are custom, i.e. format-specific. This is also the qualifying condition for something to be moved into the format config: if you can imagine an SSTable format that does not need that flag, then it belongs to the format. E.g. bloom-filter-less formats do not need {{bloom_filter_fp_chance}}, and (even though they are not a feature of writing an SSTable) only {{BIG}} requires key cache options. Unless we are certain that CRC is the only way a format could defend against bit rot, {{check_crc_chance}} is also a format-specific property. > Make sstable format configurable per table > ------------------------------------------ > > Key: CASSANDRA-18534 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18534 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Schema, Local/SSTable > Reporter: Branimir Lambov > Assignee: Maxwell Guo > Priority: Normal > Fix For: 5.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > Some SSTable format settings need to be configurable per table for better > efficiency. This includes: > - {{row_index_granularity}} > - {{bloom_filter_fp_chance}} > - {{crc_check_chance}} > - {{min/max_index_interval}} > Some of these are currently configurable using direct properties of tables. > Having them as format properties makes better sense and should also support > specifying useable combinations of settings, e.g. > {code:java} > CREATE TABLE ... WITH sstable_format = "bti-fast"; > CREATE TABLE ... WITH sstable_format = "bti-small"; > {code} > where {{bti-fast}} and {{bti-small}} can be defined in {{cassandra.yaml}} > e.g. as > {code:java} > sstable.format.options: > - bti-fast: > row_index_granularity: 1kiB > bloom_filter_fp_chance: 0.01 > - bti-small: > row_index_granularity: 32kiB > bloom_filter_fp_chance: 0.1 > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org