[
https://issues.apache.org/jira/browse/CASSANDRA-18221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773769#comment-17773769
]
David Capwell commented on CASSANDRA-18221:
-------------------------------------------
+1 to C* changes, but have a few comments about Accord side (no PR so pushing
here)
* copy/paste logic (see
https://github.com/jacek-lewandowski/cassandra-accord/compare/b1befa3cc0a8496451bb48ec3bb1c0f56b8c7653..CASSANDRA-18221#diff-0cb0a486433822ffbc29bfa8b6b27352b4d19cf026892f60866ad5c908fb8c11R164-R169).
would be good to refactor
{code}
if (failure instanceof Preempted)
node.agent().metricsEventsListener().onPreempted(txnId);
else if (failure instanceof Timeout)
node.agent().metricsEventsListener().onTimeout(txnId);
else if (failure instanceof Invalidated)
node.agent().metricsEventsListener().onInvalidated(txnId);
{code}
would be nice to have something like
node.agent().metricsEventsListener().onException(txnId, failure) and that does
these if checks by default?
* nit: node.agent().metricsEventsListener().onProgressLogSizeChange(txnId, 1);
this is a SimpleProgressLog thing, so maybe rename to
onSimpleProgressLogSizeChange to denote that its for a specific impl? same
comment for getProgressLogScheduleDelay
* i don't think accord-core/src/main/java/accord/primitives/Timestamp.java
change is correct. toString now returns a bit map but fromString thinks its a
normal integer. so the property that t == fromString(t.toString()) would be
broken... can you add tests if you wish to make such a change?
> CEP-15: (Accord) Define a configuration system for Accord to allow overriding
> of internal configs and integrate with Cassandra yaml
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-18221
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18221
> Project: Cassandra
> Issue Type: Improvement
> Components: Accord
> Reporter: David Capwell
> Assignee: Jacek Lewandowski
> Priority: Normal
> Labels: pull-request-available
> Fix For: 5.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Users are used to modifying cassandra via yaml and JMX (for dynamic configs)
> but accord does not integrate with this right now; we should enhance Accord
> to expose configs that are defined in cassandra yaml.
> As an extension on this, we should figure out which configs are “dynamic” and
> allow overriding via JMX or system vtable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
