[
https://issues.apache.org/jira/browse/CASSANDRA-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773792#comment-17773792
]
Caleb Rackliffe commented on CASSANDRA-18905:
---------------------------------------------
The 5.0 patch looks good, although I've left a few nits inline in the PR. It
also looks like we need to adjust
{{IndexGroupMetricsTest#verifyIndexGroupMetrics}} the same way we've adjusted
{{QueryMetricsTest#testMetricRelease}} to reflect the metrics being released
when the last index is dropped.
Is the {{trunk}} PR missing some test fixes? ({{QueryMetricsTest}} et al.)
Finally, a bit of OCD not related to the patch,
{{QueryMetricsTest#testSameIndexNameAcrossKeyspaces}} doesn't need its
{{throws}} clause.
> Index.Group is incorrectly unregistered from the SecondaryIndexManager
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-18905
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18905
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/2i Index
> Reporter: Mike Adamson
> Assignee: Mike Adamson
> Priority: Urgent
> Fix For: 5.0
>
>
> An Index.Group is removed from the SecondaryIndexManager during
> unregisterIndex if it contains no indexes after the index is unregistered.
> The code for removing the group uses the wrong key to remove the group from
> the indexGroups map. It is using the group object rather than the group name
> that is used as the key in the map.
> This means that the group is not added again if a new index is registered
> using that group. The knock on from this is that the
> StorageAttachedIndexGroup unregisters itself from the Tracker when it has no
> indexes after an index is removed. The same group with no tracker is then
> used for new indexes. This group then receives no notifications about sstable
> or memtable updates. The ultimate side effect of this is that, memtables are
> not released, resulting in memory leaks and indexes are not updated with new
> sstables and their associated index files.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
