This is an automated email from the ASF dual-hosted git repository.

smiklosovic pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 02307b1e alignement with CASSANDRA-18872
02307b1e is described below

commit 02307b1ea883e01f79723bfdfde223c7110df128
Author: Stefan Miklosovic <[email protected]>
AuthorDate: Thu Oct 5 13:52:41 2023 +0200

    alignement with CASSANDRA-18872
    
    patch by Stefan Miklosovic; reviewed by Branimir Lambov for CASSANDRA-18872
---
 compression_test.py | 40 +++++++++++++++++++++-------------------
 1 file changed, 21 insertions(+), 19 deletions(-)

diff --git a/compression_test.py b/compression_test.py
index 0bb63446..cb7fa88d 100644
--- a/compression_test.py
+++ b/compression_test.py
@@ -3,6 +3,7 @@ import pytest
 import logging
 
 from dtest import create_ks
+from distutils.version import LooseVersion
 from scrub_test import TestHelper
 from tools.assertions import assert_crc_check_chance_equal
 
@@ -80,25 +81,26 @@ class TestCompression(TestHelper):
         assert '256' == meta.options['compression']['chunk_length_in_kb']
         assert_crc_check_chance_equal(session, "compression_opts_table", 0.25)
 
-        warn = node.grep_log("The option crc_check_chance was deprecated as a 
compression option.")
-        assert len(warn) == 0
-        session.execute("""
-            alter table compression_opts_table
-                WITH compression = {
-                    'class': 'DeflateCompressor',
-                    'chunk_length_in_kb': 256,
-                    'crc_check_chance': 0.6
-                }
-            """)
-        warn = node.grep_log("The option crc_check_chance was deprecated as a 
compression option.")
-        assert len(warn) == 1
-
-        # check metadata again after crc_check_chance_update
-        session.cluster.refresh_schema_metadata()
-        meta = 
session.cluster.metadata.keyspaces['ks'].tables['compression_opts_table']
-        assert 'org.apache.cassandra.io.compress.DeflateCompressor' == 
meta.options['compression']['class']
-        assert '256' == meta.options['compression']['chunk_length_in_kb']
-        assert_crc_check_chance_equal(session, "compression_opts_table", 0.6)
+        if self.cluster.version() < LooseVersion('5.0'):
+          warn = node.grep_log("The option crc_check_chance was deprecated as 
a compression option.")
+          assert len(warn) == 0
+          session.execute("""
+              alter table compression_opts_table
+                  WITH compression = {
+                      'class': 'DeflateCompressor',
+                      'chunk_length_in_kb': 256,
+                      'crc_check_chance': 0.6
+                  }
+              """)
+          warn = node.grep_log("The option crc_check_chance was deprecated as 
a compression option.")
+          assert len(warn) == 1
+
+          # check metadata again after crc_check_chance_update
+          session.cluster.refresh_schema_metadata()
+          meta = 
session.cluster.metadata.keyspaces['ks'].tables['compression_opts_table']
+          assert 'org.apache.cassandra.io.compress.DeflateCompressor' == 
meta.options['compression']['class']
+          assert '256' == meta.options['compression']['chunk_length_in_kb']
+          assert_crc_check_chance_equal(session, "compression_opts_table", 0.6)
 
         for n in range(0, 100):
             session.execute("insert into compression_opts_table (id) values 
(uuid());")


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to