absurdfarce commented on code in PR #1739:
URL:
https://github.com/apache/cassandra-java-driver/pull/1739#discussion_r1381895668
##########
java-driver-parent.ipr:
##########
@@ -0,0 +1,120 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review Comment:
In general we don't check in internal IntelliJ files. Both this .ipr file
and the .iws file below fall into this category so my suggestion would be to
remove these from your PR!
##########
core/src/main/java/com/datastax/oss/driver/api/core/data/CqlVector.java:
##########
@@ -84,7 +84,7 @@ public static <V extends Number> CqlVector<V>
newInstance(List<V> list) {
* </code> call on some CqlVector should return a CqlVector that is equal to
the origin instance.
*
* @param str a String representation of a CqlVector
- * @param subtypeCodec
+ * @param subtypeCodec the TypeCodec to parse the String representation
Review Comment:
This is true but it doesn't really tell us which string representation we're
talking about :)
Vectors in CQL have a form that looks something like this:
```
org.apache.cassandra.db.marshal.VectorType(org.apache.cassandra.db.marshal.FloatType,3)
```
The first parameter there is the subtype of this vector, that is the type of
values it contains. The second is it's size parameter.
The subtypeCodec in CqlVector is intended to parse the string representation
of the subtype so that we can build new instances of that subtype for the
values contained by the vector. So you probably want to say something like
"the codec to parse the string representation of subtype values" here (or
something similar) in order to make it very clear what values we're talking
about.
Make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
