[
https://issues.apache.org/jira/browse/CASSANDRA-18314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783237#comment-17783237
]
Stefan Miklosovic commented on CASSANDRA-18314:
-----------------------------------------------
(1) tests that "me" sstables (from 3.0) as well as all previous formats are
loadable into 5.0
(2) there are commit log upgrade tests well like this, we are testing the
commitlog upgrade for 3.4 only, I am not sure why but I guess we just stopped
to do this and forgot about that test completely. There is a maker of commit
logs like this (3), that exists on 3.0 branch too so we just need to generate
commit logs for each respective version in MessagingService, copy them over to
5.0 and add loading test.
When it comes to hints, there is not any test similar to what we do for commit
logs. For hints, we would need to create makers for such hint files for each
version in MS and then test the loading / replaying it in 5.0.
I do not have any reason to believe that hints would be any different from
sstables and commitlogs when it comes to their loading / upgrading from times
of 3.0 / 3.11. We may close this ticket and create a new one which will cover
all the versions in MS as described above and we may reopen this ticket once
there is any problem with it.
(1)
https://github.com/apache/cassandra/blob/cassandra-5.0/test/unit/org/apache/cassandra/io/sstable/LegacySSTableTest.java#L104
(2)
https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/db/commitlog/CommitLogUpgradeTest.java#L108
(3)
https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/db/commitlog/CommitLogUpgradeTestMaker.java
> Lift MessagingService.minimum_version to 40
> -------------------------------------------
>
> Key: CASSANDRA-18314
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18314
> Project: Cassandra
> Issue Type: Task
> Components: Messaging/Internode
> Reporter: Michael Semb Wever
> Assignee: Michael Semb Wever
> Priority: Normal
> Fix For: 5.0, 5.0-beta
>
> Time Spent: 15h 20m
> Remaining Estimate: 0h
>
> MessagingService's VERSION_30 and VERSION_3014 don't have to be supported in
> Cassandra 5.0 anymore.
> (Cassandra 5.0 currently is still using VERSION_40)
> Patch:
> https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18314/trunk
> Raises the question whether backward compatibility to the previous major is
> defined by the Cassandra version or by the internal component version
> (MessagingService).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
