[
https://issues.apache.org/jira/browse/CASSANDRA-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784223#comment-17784223
]
Brandon Williams edited comment on CASSANDRA-18710 at 11/8/23 10:43 PM:
------------------------------------------------------------------------
I noticed that the refactoring around this in CASSANDRA-17071 kept the general
order of events but slightly changed the behavior, which I've restored
[here|https://github.com/driftx/cassandra/commit/b25d1819faf3a963e6e40a2afe6b9e648c4d2aee].
-As one might expect, I haven't been able to reproduce in 5.0 with that patch
([here|https://app.circleci.com/pipelines/github/driftx/cassandra/1362/workflows/ccc0dc0b-7342-4637-a983-160b3f3a6ea5]
or
[here|https://app.circleci.com/pipelines/github/driftx/cassandra/1362/workflows/c35b0923-d293-4197-a58d-7498ab499e09]).
If this looks good and will still work for CASSANDRA-17071's goals, I can
prepare the branches and run full CI.-
This did reproduce after I wrote that,
[here|https://app.circleci.com/pipelines/github/driftx/cassandra/1362/workflows/ccc0dc0b-7342-4637-a983-160b3f3a6ea5].
I'll have to dig into that.
was (Author: brandon.williams):
I noticed that the refactoring around this in CASSANDRA-17071 kept the general
order of events but slightly changed the behavior, which I've restored
[here|https://github.com/driftx/cassandra/commit/b25d1819faf3a963e6e40a2afe6b9e648c4d2aee].
As one might expect, I haven't been able to reproduce in 5.0 with that patch
([here|https://app.circleci.com/pipelines/github/driftx/cassandra/1362/workflows/ccc0dc0b-7342-4637-a983-160b3f3a6ea5]
or
[here|https://app.circleci.com/pipelines/github/driftx/cassandra/1362/workflows/c35b0923-d293-4197-a58d-7498ab499e09]).
If this looks good and will still work for CASSANDRA-17071's goals, I can
prepare the branches and run full CI.
> Test failure:
> org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize-.jdk17 (from
> org.apache.cassandra.io.DiskSpaceMetricsTest-.jdk17)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-18710
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18710
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Ekaterina Dimitrova
> Assignee: Brandon Williams
> Priority: Normal
> Fix For: 4.1.x, 5.0-beta, 5.0.x, 5.x
>
> Attachments: org.apache.cassandra.io.DiskSpaceMetricsTest.txt
>
>
> Seen here:
> [https://ci-cassandra.apache.org/job/Cassandra-trunk/1644/testReport/org.apache.cassandra.io/DiskSpaceMetricsTest/testFlushSize__jdk17/]
> h3.
> {code:java}
> Error Message
> expected:<7200.0> but was:<1367.83970468544>
> Stacktrace
> junit.framework.AssertionFailedError: expected:<7200.0> but
> was:<1367.83970468544> at
> org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize(DiskSpaceMetricsTest.java:119)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
