[ 
https://issues.apache.org/jira/browse/CASSANDRA-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103140#comment-13103140
 ] 

Jonathan Ellis commented on CASSANDRA-3183:
-------------------------------------------

I don't think you can actually end up w/ a null r_c_p so this is unnecessary?

{code}
-        writeAttr(sb, false, "row_cache_provider", 
normaliseType(cfDef.row_cache_provider, "org.apache.cassandra.cache"));
+        writeAttr(sb, false, "row_cache_provider", cfDef.row_cache_provider == 
null ? "" : cfDef.row_cache_provider);
{code}

> Make SerializingCacheProvider the default if JNA is available
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-3183
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3183
>             Project: Cassandra
>          Issue Type: Task
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 1.0.0
>
>         Attachments: 3183-additions.patch, 3183-alt.patch, 3183.txt, 
> CASSANDRA-3183-alt-v2.patch, CASSANDRA-3183-alt-v3.patch
>
>
> The serializing cache is a better choice for most users:
> - Lower total memory usage (serialized data is usually 8x-12x smaller than 
> "live" data in the JVM with all the overhead that involves) means you can 
> cache more rows for a given memory footprint
> - Moving the serialized rows off-heap means you can use smaller heaps, 
> reducing the impact of GC pauses

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to