[
https://issues.apache.org/jira/browse/CASSANDRA-18757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788858#comment-17788858
]
Ethan Brown edited comment on CASSANDRA-18757 at 11/22/23 6:42 PM:
-------------------------------------------------------------------
[~smiklosovic] I split the test into 4 separate tests (1 for each case). The
reason for the 1 minute wait is to allow the {{overlapIterator }}to refresh.{{
runMayThrow()}} in {{CompactionTask.java}} only refreshes the
{{overlapIterator}} if 1 minute has passed since the last refresh.
[https://github.com/apache/cassandra/blob/cassandra-5.0/src/java/org/apache/cassandra/db/compaction/CompactionTask.java#L219]
was (Author: JIRAUSER302087):
[~smiklosovic] I split the test into 4 separate tests (1 for each case). The
reason for the 1 minute wait is to allow the {{overlapIterator }}to refresh.
{{runMayThrow()}} in {{CompactionTask.java}} only refreshes the
{{overlapIterator}} if 1 minute has passed since the last refresh.
https://github.com/apache/cassandra/blob/cassandra-5.0/src/java/org/apache/cassandra/db/compaction/CompactionTask.java#L219
> UnifiedCompactionTask is incorrectly setting keepOriginals
> ----------------------------------------------------------
>
> Key: CASSANDRA-18757
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18757
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
> Reporter: Branimir Lambov
> Assignee: Ethan Brown
> Priority: Normal
> Fix For: 5.0-beta, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code:java}
> super(cfs, txn, gcBefore,
> strategy.getController().getIgnoreOverlapsInExpirationCheck());{code}
> in {{UnifiedCompactionTask}} is calling the base constructor
> {code:java}
> public CompactionTask(ColumnFamilyStore cfs, LifecycleTransaction txn, long
> gcBefore, boolean keepOriginals)
> {code}
> which can set {{keepOriginals}} to true when it should not be.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
