[
https://issues.apache.org/jira/browse/CASSANDRA-17062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792585#comment-17792585
]
Maxim Muzafarov commented on CASSANDRA-17062:
---------------------------------------------
[~smiklosovic] Although CASSANDRA-14572 and CASSANDRA-17062 (this one) have
some overlap for exporting of auth metrics via virtual tables, I still think
that it is worthwhile to implement auth cache metrics as it described in the
issue desctipon with a caviat to the system_views.auth_cache_metrics virtual
table.
As part of 14572, metrics will be represented as metric types and all metric
groups which are located under the org.apache.cassandra.metrics package will be
exposed to virtual tables out of the box, corresponding to the same metric
group names as they have now. The only requirement is that they must be
registered in the MetricsRegistry.
So we have two options to go:
# If the 14572 and 17062 are targeted for the same release, e.g. 5.2 the
auth_cache_metrics virtual table will be exposed as a part of the 14572 work,
so there is no need to include the implementation of this virtual table in the
current patch. We need the JMX side and the registration in the MetricsRegistry.
# Considering how long it takes to deliver the CASSANDRA-15254, I can expect
the same delay and issues with 14572. So we can implement everything related to
CASSANDRA-17062 here, and then wait for the 14572 to be ready at some point in
time in the future.
Of course, I prefer the former option, as it reduces the number of changes for
the patch, plus we avoid implementing another boilerplate virtual table. I
guess, which way to go is up to you as an author of the patch.
> Expose Auth Caches metrics to virtual table
> -------------------------------------------
>
> Key: CASSANDRA-17062
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17062
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Virtual Tables, Observability/Metrics,
> Tool/nodetool
> Reporter: Aleksei Zotov
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Unlike to other caches (row, key, counter), Auth Caches lack some monitoring
> capabilities. Here are a few particular changes to get this inequity fixed:
> # Add auth caches to _system_views.caches_ VT
> # Expose auth caches metrics via JMX
> # Add auth caches details to _nodetool info_
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
