[
https://issues.apache.org/jira/browse/CASSANDRA-17062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792586#comment-17792586
]
Stefan Miklosovic edited comment on CASSANDRA-17062 at 12/3/23 9:53 PM:
------------------------------------------------------------------------
[~mmuzaf]
I also prefer 1). The thing is that once we implement this and we commit it
into trunk, that becomes 5.1 and then 14572 will be, ideally, done in 5.2 (that
seems to be the release you are targeting). So in 5.2, we would deprecate this
just to incorporate it into 14572? Not good.
I do not think there is any actual need to rush this ticket. We can just
include it into 14572. That is what I wrote in my last comment, I prefer to
take more holistic approach to this instead of rewriting it later.
I took a look at your patch and it seems to me that while we are on a good
track, it takes some time to integrate all metrics into it.
The third approach could be that we rework the hierarchy of these two
particular cache metrics (it will be visible from the PR), it is easy to
logically separate the vtables implementations from the refactoring of the
caches themselves, and we could fully focus just to metrics in vtables in your
work in 14572 afterwards. [~samt] does this make sense to you too?
was (Author: smiklosovic):
[~mmuzaf]
I also prefer 1). The thing is that once we implement this and we commit it
into trunk, that becomes 5.1 and then 14572 will be, ideally, done in 5.2 (that
seems to be the release you are targeting). So in 5.2, we would deprecate this
just to incorporate it into 14572? Not good.
I do not think there is any actual need to rush this ticket. We can just
include it into 14572. That is what I wrote in my last comment, I prefer to
take more holistic approach to this instead of rewriting it later.
I took a look into your patch and it seems to me that while we are on a good
track, it takes some time to integrate all metrics into it.
The third approach could be that we rework the hierarchy of these two
particular cache metrics (it will be visible from the PR), it is easy to
logically separate the vtables implementations from the refactoring of the
caches themselves, and we could fully focus just for metrics in vtables in your
work in 14572 afterwards. [~samt] does this make sense to you too?
> Expose Auth Caches metrics to virtual table
> -------------------------------------------
>
> Key: CASSANDRA-17062
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17062
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Virtual Tables, Observability/Metrics,
> Tool/nodetool
> Reporter: Aleksei Zotov
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Unlike to other caches (row, key, counter), Auth Caches lack some monitoring
> capabilities. Here are a few particular changes to get this inequity fixed:
> # Add auth caches to _system_views.caches_ VT
> # Expose auth caches metrics via JMX
> # Add auth caches details to _nodetool info_
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
