frankgh commented on code in PR #19:
URL:
https://github.com/apache/cassandra-analytics/pull/19#discussion_r1414720469
##########
cassandra-bridge/src/main/java/org/apache/cassandra/spark/data/CqlField.java:
##########
@@ -263,7 +263,7 @@ public CqlField(boolean isPartitionKey,
this.isPartitionKey = isPartitionKey;
this.isClusteringColumn = isClusteringColumn;
this.isStaticColumn = isStaticColumn;
- this.name = name.replaceAll("\"", "");
+ this.name = name;
Review Comment:
ok, took a deeper look. I think the confusion is mainly on the EndToEnd
testing code. So what I've done is address the test setup in testing code. I
have made it so that we always quote the fields, when quotes are needed for
testing purposes.
I have also added a test case that validates the column filter
(`PartialRowBuilder` class). That way we guarantee that we are able to retrieve
columns that are requested in the schema where columns are case sensitive in
Cassandra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
