[ 
https://issues.apache.org/jira/browse/CASSANDRA-18902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798386#comment-17798386
 ] 

Ekaterina Dimitrova commented on CASSANDRA-18902:
-------------------------------------------------

[~jlewandowski] , thank you. Everything looks good except for one small 
comment. 
{quote} - the version is not re-read from the properties files - once it has 
been read, its value is memoized{quote}
This is a nice improvement, and those should go only to trunk. Also, I left 
[this|https://github.com/apache/cassandra/pull/2984#discussion_r1430762476] and 
[this|https://github.com/apache/cassandra/pull/2984#discussion_r1430762476] 
comment, why getting rid of the "debug_version"?

> Test failure: 
> org.apache.cassandra.distributed.test.MigrationCoordinatorTest.explicitEndpointIgnore
> ---------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-18902
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18902
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/dtest/java
>            Reporter: Jacek Lewandowski
>            Assignee: Jacek Lewandowski
>            Priority: Normal
>             Fix For: 4.1.x, 5.0-rc, 5.x
>
>
> Repeated run from `cassandra-4.1` 
> [https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/941/workflows/46fc6cb7-135e-4862-b9d3-6996c0993de8]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to