[ 
https://issues.apache.org/jira/browse/CASSANDRA-19046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808849#comment-17808849
 ] 

Brandon Williams commented on CASSANDRA-19046:
----------------------------------------------

Fixing ClientMetricsTest.testPaxosStatement requires deciding on if we should 
add the metrics, or exempt them in the test for v2.

QueriesTablesTest passes for v1 when it sends a Commit and that is then 
converted to a 
[string|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/paxos/Commit.java#L340]
 in the queries table that matches.  v2 doesn't use Commit and I'm not sure 
where to add an equivalent that will appear there, but it seems to have value 
if it's going to be visible in the table.

Do you have any guidance on those points, [~benedict]?

[Here|https://app.circleci.com/pipelines/github/driftx/cassandra/1460/workflows/5bae89db-18db-4311-b314-4a7641ce5a9f/jobs/71554]
 is 500 repetitions of client_request_metrics_test.TestClientRequestMetrics 
from [this 
branch|https://github.com/driftx/cassandra-dtest/tree/CASSANDRA-19046].




> Paxos V2 does not update individual fields of readMetrics
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-19046
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19046
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Feature/Lightweight Transactions, Observability/Metrics
>            Reporter: Branimir Lambov
>            Assignee: Brandon Williams
>            Priority: Normal
>             Fix For: 4.1.x, 5.0-rc, 5.x
>
>
> As a result, {{ClientRequestMetricsTest.testPaxosStatement}} is failing with 
> {{{}paxos_variant: v2{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to