yifan-c commented on code in PR #36:
URL:
https://github.com/apache/cassandra-analytics/pull/36#discussion_r1469800535
##########
cassandra-four-zero/src/main/java/org/apache/cassandra/bridge/CassandraBridgeImplementation.java:
##########
@@ -164,13 +166,31 @@ public static synchronized void setup()
throw new RuntimeException(exception);
}
config.data_file_directories = new
String[]{tempDirectory.toString()};
+ setupCommitLogConfigs(tempDirectory);
DatabaseDescriptor.setEndpointSnitch(new SimpleSnitch());
Keyspace.setInitialized();
setup = true;
}
}
+ public static void setupCommitLogConfigs(Path path)
+ {
+ String commitLogPath = path + "/commitlog";
Review Comment:
It should not be necessary. But the current library requires the config to
be present. The code path that checks/loads the config is when getting the
local host uuid. Seemingly related with newly added CMS. Setting the config is
not a big deal, so it is not burning issue unless I missed something.
1. `org.apache.cassandra.io.sstable.SSTableSimpleWriter#getOrCreateWriter`
2. `org.apache.cassandra.io.sstable.AbstractSSTableSimpleWriter#createWriter`
3. `org.apache.cassandra.io.sstable.SimpleSSTableMultiWriter#create`
4.
`org.apache.cassandra.io.sstable.metadata.MetadataCollector#MetadataCollector(org.apache.cassandra.db.ClusteringComparator)`
5. `org.apache.cassandra.service.StorageService#getLocalHostUUID`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
