[
https://issues.apache.org/jira/browse/CASSANDRA-19333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813428#comment-17813428
]
Bret McGuire commented on CASSANDRA-19333:
------------------------------------------
Thanks for the PR [~e.dimitrova] !
That CONTRIBUTING.md doc is what I was going to point you at; it probably needs
an update to account for a few changes after the donation to the ASF but most
of the technical stuff should largely be correct. Unfortunately the state of
CI is still in flux; work is ongoing to get ASF CI support up and running and
we're working on updating the DataStax Jenkins instance to run tests for forked
PRs. Neither of those are in a completed state at the moment. So running the
tests locally is prolly the right answer for the very short-term. Specifically
for this change VectorCodecTest will really be the clincher. That test
includes a test case which tries to decode a vector with multiple elements. If
that test succeeds we can be reasonably confident that the ByteBuffer
processing changes are solid. They also _look_ sane as well, which is always
nice.
I'll try to finish up a review of this tonight but on a quick glance it doesn't
look like there's anything terribly controversial here.
> Fix decode in VectorCodec
> -------------------------
>
> Key: CASSANDRA-19333
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19333
> Project: Cassandra
> Issue Type: Bug
> Components: Client/java-driver
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
>
> We made a server-side fix in CASSANDRA-19167 for VectorCodec.
> This needs to be checked also in the driver [here
> |https://github.com/apache/cassandra-java-driver/blob/8d5849cb38995b312f29314d18256c0c3e94cf07/core/src/main/java/com/datastax/oss/driver/internal/core/type/codec/VectorCodec.java#L130-L139]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
