Author: jbellis
Date: Mon Sep 19 16:50:46 2011
New Revision: 1172698
URL: http://svn.apache.org/viewvc?rev=1172698&view=rev
Log:
Remove dynamic_snitch boolean from example configuration
patch by jbellis; reviewed by brandonwilliams for CASSANDRA-3229
Modified:
cassandra/branches/cassandra-1.0.0/CHANGES.txt
cassandra/branches/cassandra-1.0.0/conf/cassandra.yaml
cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/config/Config.java
Modified: cassandra/branches/cassandra-1.0.0/CHANGES.txt
URL:
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0.0/CHANGES.txt?rev=1172698&r1=1172697&r2=1172698&view=diff
==============================================================================
--- cassandra/branches/cassandra-1.0.0/CHANGES.txt (original)
+++ cassandra/branches/cassandra-1.0.0/CHANGES.txt Mon Sep 19 16:50:46 2011
@@ -6,6 +6,8 @@
* Log message when a full repair operation completes (CASSANDRA-3207)
* Fix streamOutSession keeping sstables references forever if the remote end
dies (CASSANDRA-3216)
+ * Remove dynamic_snitch boolean from example configuration (defaulting to
+ true) and set default badness threshold to 0.1 (CASSANDRA-3229)
1.0.0-beta1
Modified: cassandra/branches/cassandra-1.0.0/conf/cassandra.yaml
URL:
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0.0/conf/cassandra.yaml?rev=1172698&r1=1172697&r2=1172698&view=diff
==============================================================================
--- cassandra/branches/cassandra-1.0.0/conf/cassandra.yaml (original)
+++ cassandra/branches/cassandra-1.0.0/conf/cassandra.yaml Mon Sep 19 16:50:46
2011
@@ -331,11 +331,6 @@ rpc_timeout_in_ms: 10000
# explicitly configured in cassandra-topology.properties.
endpoint_snitch: org.apache.cassandra.locator.SimpleSnitch
-# dynamic_snitch -- This boolean controls whether the above snitch is
-# wrapped with a dynamic snitch, which will monitor read latencies
-# and avoid reading from hosts that have slowed (due to compaction,
-# for instance)
-dynamic_snitch: true
# controls how often to perform the more expensive part of host score
# calculation
dynamic_snitch_update_interval_in_ms: 100
@@ -349,7 +344,7 @@ dynamic_snitch_reset_interval_in_ms: 600
# expressed as a double which represents a percentage. Thus, a value of
# 0.2 means Cassandra would continue to prefer the static snitch values
# until the pinned host was 20% worse than the fastest.
-dynamic_snitch_badness_threshold: 0.0
+dynamic_snitch_badness_threshold: 0.1
# request_scheduler -- Set this to a class that implements
# RequestScheduler, which will schedule incoming client requests
Modified:
cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/config/Config.java
URL:
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/config/Config.java?rev=1172698&r1=1172697&r2=1172698&view=diff
==============================================================================
---
cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/config/Config.java
(original)
+++
cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/config/Config.java
Mon Sep 19 16:50:46 2011
@@ -99,10 +99,10 @@ public class Config
public Integer commitlog_sync_period_in_ms;
public String endpoint_snitch;
- public Boolean dynamic_snitch = false;
+ public Boolean dynamic_snitch = true;
public Integer dynamic_snitch_update_interval_in_ms = 100;
public Integer dynamic_snitch_reset_interval_in_ms = 600000;
- public Double dynamic_snitch_badness_threshold = 0.0;
+ public Double dynamic_snitch_badness_threshold = 0.1;
public String request_scheduler;
public RequestSchedulerId request_scheduler_id;