[ 
https://issues.apache.org/jira/browse/CASSANDRA-19422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820036#comment-17820036
 ] 

Stefan Miklosovic edited comment on CASSANDRA-19422 at 2/23/24 12:12 PM:
-------------------------------------------------------------------------

OK so scm.url on github, all other links in scm on gitbox?

Also, should not we also reference a branch? E.g for 3.0 it would be like this: 

{noformat}
<property name="scm.url" 
value="https://github.com/apache/cassandra/tree/cassandra-3.0"/>
{noformat}

It just feels weird to have a url which takes us to trunk in GH.

This would be also visible in Maven pom's like here 

https://github.com/apache/cassandra/blob/cassandra-3.0/build.xml#L311


was (Author: smiklosovic):
OK so scm.url on github, all other links in scm on gitbox?

Also, should not we also reference a branch? E.g for 3.0 it would be like this: 

{noformat}
<property name="scm.url" 
value="https://github.com/apache/cassandra/tree/cassandra-3.0"/>
{noformat}

It just feels weird to have a url which takes us to trunk in GH.

> Fix Git repository links
> ------------------------
>
>                 Key: CASSANDRA-19422
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19422
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Build, CI
>            Reporter: Stefan Miklosovic
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> I am creating an issue based on this PR (1)
> (1) https://github.com/apache/cassandra/pull/3120



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to