[
https://issues.apache.org/jira/browse/CASSANDRA-19409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820160#comment-17820160
]
Ekaterina Dimitrova edited comment on CASSANDRA-19409 at 2/25/24 2:39 PM:
--------------------------------------------------------------------------
{quote}Also those tests are decorated to timeout at 3000!! not 900.
{quote}
Great observation! We must fix the timeout if they are decorated and the
timeout is overwritten.
I think pytest.ini should contain:
{code:java}
addopts = --show-capture=stdout --timeout=900{code}
instead of
{code:java}
timeout = 900{code}
.
I tested locally:
1) If I set it globally addopts = --show-capture=stdout --timeout=5 in
pytest.ini and run some tests, they timeout in 5s.
2) If I return to addopts = --show-capture=stdout --timeout=900 in pytest.ini
and run a test with @pytest.mark.timeout(5), the test time outs in 5 seconds so
the decoration is accepted.
3) If I set addopts = --show-capture=stdout --timeout=3 in pytest.ini and run
a test with @pytest.mark.timeout(5), the test time outs in 5 seconds so the
decoration is accepted and this was the case we were interested in.
We do not use this decoration for many tests, but on a quick glance, it seems
that where we use it is acceptable.
Patch PR: [https://github.com/apache/cassandra-dtest/pull/254]
{quote}I don't agree they started failing suddenly. That 900 timeout in upgrade
tests I have been seeing for years in jenkins.
{quote}
All tests mentioned here failed on every run since the beginning of January on
5.0. See example - runs #151 to 169
[https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-5.0/failure/upgrade_tests.upgrade_through_versions_test/TestProtoV3Upgrade_AllVersions_EndsAt_Trunk_HEAD/test_parallel_upgrade_with_internode_ssl]
Since last week, they have been flaky again, so it may have been just some bad
time, I'm not sure.
I see them failing every now and then only on trunk:
[https://butler.cassandra.apache.org/#/ci/upstream/compare/Cassandra-trunk/trunk]
and 4.1:
[https://butler.cassandra.apache.org/#/ci/upstream/compare/Cassandra-4.1/cassandra-4.1]
was (Author: e.dimitrova):
{quote}Also those tests are decorated to timeout at 3000!! not 900.
{quote}
Great observation! We must fix the timeout if they are decorated and the
timeout is overwritten.
I think pytest.ini should contain:
{code:java}
addopts = --show-capture=stdout --timeout=900{code}
instead of
{code:java}
timeout = 900{code}
.
I tested locally:
1) If I set it globally addopts = --show-capture=stdout --timeout=5 in
pytest.ini and run some tests, they timeout in 5s.
2) If I return to addopts = --show-capture=stdout --timeout=5 in pytest.ini
and run a test with @pytest.mark.timeout(5), the test time outs in 5 seconds so
the decoration is accepted.
We do not use this decoration for many tests, but on a quick glance, it seems
that where we use it is acceptable.
Patch PR: https://github.com/apache/cassandra-dtest/pull/254
{quote}I don't agree they started failing suddenly. That 900 timeout in upgrade
tests I have been seeing for years in jenkins.
{quote}
All tests mentioned here failed on every run since the beginning of January on
5.0. See example - runs #151 to 169
https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-5.0/failure/upgrade_tests.upgrade_through_versions_test/TestProtoV3Upgrade_AllVersions_EndsAt_Trunk_HEAD/test_parallel_upgrade_with_internode_ssl
Since last week, they have been flaky again, so it may have been just some bad
time, I'm not sure.
I see them failing every now and then only on trunk:
[https://butler.cassandra.apache.org/#/ci/upstream/compare/Cassandra-trunk/trunk]
and 4.1:
[https://butler.cassandra.apache.org/#/ci/upstream/compare/Cassandra-4.1/cassandra-4.1]
> Test Failure: dtest-upgrade.upgrade_tests.upgrade_through_versions_test.*
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-19409
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19409
> Project: Cassandra
> Issue Type: Bug
> Components: CI
> Reporter: Ekaterina Dimitrova
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 5.0-rc
>
>
> Failing in Jenkins:
> *
> [dtest-upgrade-novnode-large.upgrade_tests.upgrade_through_versions_test.TestProtoV4Upgrade_AllVersions_EndsAt_Trunk_HEAD.test_parallel_upgrade_with_internode_ssl|https://ci-cassandra.apache.org/job/Cassandra-5.0/170/testReport/junit/dtest-upgrade-novnode-large.upgrade_tests.upgrade_through_versions_test/TestProtoV4Upgrade_AllVersions_EndsAt_Trunk_HEAD/test_parallel_upgrade_with_internode_ssl/]
> *
> [dtest-upgrade-novnode-large.upgrade_tests.upgrade_through_versions_test.TestProtoV4Upgrade_AllVersions_RandomPartitioner_EndsAt_Trunk_HEAD.test_parallel_upgrade_with_internode_ssl|https://ci-cassandra.apache.org/job/Cassandra-5.0/170/testReport/junit/dtest-upgrade-novnode-large.upgrade_tests.upgrade_through_versions_test/TestProtoV4Upgrade_AllVersions_RandomPartitioner_EndsAt_Trunk_HEAD/test_parallel_upgrade_with_internode_ssl/]
> *
> [dtest-upgrade-novnode.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_EndsAt_Trunk_HEAD.test_parallel_upgrade|https://ci-cassandra.apache.org/job/Cassandra-5.0/170/testReport/junit/dtest-upgrade-novnode.upgrade_tests.upgrade_through_versions_test/TestProtoV3Upgrade_AllVersions_EndsAt_Trunk_HEAD/test_parallel_upgrade/]
> *
> [dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV4Upgrade_AllVersions_RandomPartitioner_EndsAt_Trunk_HEAD.test_parallel_upgrade|https://ci-cassandra.apache.org/job/Cassandra-5.0/170/testReport/junit/dtest-upgrade.upgrade_tests.upgrade_through_versions_test/TestProtoV4Upgrade_AllVersions_RandomPartitioner_EndsAt_Trunk_HEAD/test_parallel_upgrade/]
> *
> [dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV4Upgrade_AllVersions_RandomPartitioner_EndsAt_Trunk_HEAD.test_parallel_upgrade_with_internode_ssl|https://ci-cassandra.apache.org/job/Cassandra-5.0/170/testReport/junit/dtest-upgrade.upgrade_tests.upgrade_through_versions_test/TestProtoV4Upgrade_AllVersions_RandomPartitioner_EndsAt_Trunk_HEAD/test_parallel_upgrade_with_internode_ssl/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
