[
https://issues.apache.org/jira/browse/CASSANDRA-19448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821988#comment-17821988
]
Maxwell Guo edited comment on CASSANDRA-19448 at 2/29/24 7:58 AM:
------------------------------------------------------------------
I don't think this is a bug. This just can ensure that cassandra can ensure the
rpo to second level, as the description
[here|https://github.com/apache/cassandra/blob/trunk/conf/commitlog_archiving.properties#L39]
for restore_point_in_time
do not say that we guarantee the rpo can be microseconds level or some other
level.
I think this issue can be marked as an improvement. And I think the
requirements raised by this issue are very meaningful.As I also encountered
this problem when doing backup and restore for cassandra before.
If this issue is unassigned ,I think I may do some help. :D
was (Author: maxwellguo):
I don't think this is a bug. This just can ensure that cassandra can ensure the
rpo to second level, as the description
[here|https://github.com/apache/cassandra/blob/trunk/conf/commitlog_archiving.properties#L39]
for restore_point_in_time
do not say that we guarantee the rpo can be microseconds level or some other
level.
I think this issue can be marked as an improvement. And I think the
requirements raised by this issue are very meaningful.As I also encountered
this problem when doing backup and restore for cassandra before.
If this issue is not assigned ,I think I may do some help. :D
> CommitlogArchiver only has granularity to seconds for restore_point_in_time
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-19448
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19448
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Commit Log
> Reporter: Jeremy Hanna
> Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
>
> Commitlog archiver allows users to backup commitlog files for the purpose of
> doing point in time restores. The [configuration
> file|https://github.com/apache/cassandra/blob/trunk/conf/commitlog_archiving.properties]
> gives an example of down to the seconds granularity but then asks what
> whether the timestamps are microseconds or milliseconds - defaulting to
> microseconds. Because the [CommitLogArchiver uses a second based date
> format|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogArchiver.java#L52],
> if a user specifies to restore at something at a lower granularity like
> milliseconds or microseconds, that means that the it will truncate everything
> after the second and restore to that second. So say you specify a
> restore_point_in_time like this:
> restore_point_in_time=2024:01:18 17:01:01.623392
> it will silently truncate everything after the 01 seconds. So effectively to
> the user, it is missing updates between 01 and 01.623392.
> This appears to be a bug in the intent. We should allow users to specify
> down to the millisecond or even microsecond level. If we allow them to
> specify down to microseconds for the restore point in time, then it may
> internally need to change from a long.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
