[ 
https://issues.apache.org/jira/browse/CASSANDRA-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824412#comment-17824412
 ] 

Stefan Miklosovic commented on CASSANDRA-14572:
-----------------------------------------------

[CASSANDRA-14572|https://github.com/instaclustr/cassandra/tree/CASSANDRA-14572]
{noformat}
java17_pre-commit_tests                         
  ✓ j17_build                                        4m 43s
  ✓ j17_cqlsh_dtests_py311                           6m 40s
  ✓ j17_cqlsh_dtests_py311_vnode                      7m 0s
  ✓ j17_cqlsh_dtests_py38                            6m 29s
  ✓ j17_cqlsh_dtests_py38_vnode                      7m 28s
  ✓ j17_cqlshlib_cython_tests                         8m 4s
  ✓ j17_cqlshlib_tests                               7m 12s
  ✓ j17_dtests                                      37m 20s
  ✓ j17_dtests_vnode                                34m 14s
  ✓ j17_unit_tests                                  11m 47s
  ✓ j17_utests_oa                                    13m 2s
  ✕ j17_jvm_dtests                                  28m 11s
  ✕ j17_jvm_dtests_vnode                            22m 53s
java17_separate_tests                            
java11_pre-commit_tests                         
java11_separate_tests                            
{noformat}

[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3960/workflows/6095a8a5-a743-49f9-82ac-f22da431697e]
[java17_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3960/workflows/cab3a70e-feba-4cca-9f48-d3a067759404]
[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3960/workflows/7eac0186-fecf-4a43-8bfd-d83fc627414e]
[java11_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3960/workflows/db402d02-1e92-41e1-b701-eae37db624fe]


> Expose all table metrics in virtual table
> -----------------------------------------
>
>                 Key: CASSANDRA-14572
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14572
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Legacy/Observability, Observability/Metrics
>            Reporter: Chris Lohfink
>            Assignee: Maxim Muzafarov
>            Priority: Low
>              Labels: virtual-tables
>             Fix For: 5.x
>
>         Attachments: flight_recording_1270017199_13.jfr, keyspayces_group 
> responses times.png, keyspayces_group summary.png, select keyspaces_group by 
> string prefix.png, select keyspaces_group compare with wo.png, select 
> keyspaces_group without value.png, systemv_views.metrics_dropped_message.png, 
> thread_pools benchmark.png
>
>          Time Spent: 7h
>  Remaining Estimate: 0h
>
> While we want a number of virtual tables to display data in a way thats great 
> and intuitive like in nodetool. There is also much for being able to expose 
> the metrics we have for tooling via CQL instead of JMX. This is more for the 
> tooling and adhoc advanced users who know exactly what they are looking for.
> *Schema:*
> Initial idea is to expose data via {{((keyspace, table), metric)}} with a 
> column for each metric value. Could also use a Map or UDT instead of the 
> column based that can be a bit more specific to each metric type. To that end 
> there can be a {{metric_type}} column and then a UDT for each metric type 
> filled in, or a single value with more of a Map<Text, Text> style. I am 
> purposing the column type though as with {{ALLOW FILTERING}} it does allow 
> more extensive query capabilities.
> *Implementations:*
> * Use reflection to grab all the metrics from TableMetrics (see: 
> CASSANDRA-7622 impl). This is easiest and least abrasive towards new metric 
> implementors... but its reflection and a kinda a bad idea.
> * Add a hook in TableMetrics to register with this virtual table when 
> registering
> * Pull from the CassandraMetrics registery (either reporter or iterate 
> through metrics query on read of virtual table)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to