SiyaoIsHiding commented on code in PR #1743:
URL:
https://github.com/apache/cassandra-java-driver/pull/1743#discussion_r1516914752
##########
core/src/main/java/com/datastax/oss/driver/internal/core/util/concurrent/ReplayingEventFilter.java:
##########
@@ -82,6 +82,7 @@ public void markReady() {
consumer.accept(event);
}
} finally {
+ recordedEvents.clear();
Review Comment:
ReplayingEventFilter works like a buffer. It holds a list (queue) of Events
since its state is STARTED, and consumes all of them when its state becomes
READY all at once. However, the list of the events is never cleared. They leak
strong references for the nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
