This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch cassandra-4.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-4.0 by this push:
new a2fbb17867 Push LocalSessions info logs to debug
a2fbb17867 is described below
commit a2fbb17867469f83b94718d052b6c371f089ec5f
Author: arkn98 <[email protected]>
AuthorDate: Mon Mar 11 13:27:39 2024 -0400
Push LocalSessions info logs to debug
Patch by arkn98; reviewed by bereng and brandonwilliams for CASSANDRA-18335
---
CHANGES.txt | 1 +
.../cassandra/repair/consistent/LocalSessions.java | 34 +++++++++++-----------
2 files changed, 18 insertions(+), 17 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index f2712c5088..69f8be60a5 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
4.0.13
+ * Push LocalSessions info logs to debug (CASSANDRA-18335)
* Filter remote DC replicas out when constructing the initial replica plan
for the local read repair (CASSANDRA-19120)
* Remove redundant code in StorageProxy#sendToHintedReplicas (CASSANDRA-19412)
* Remove bashisms for mx4j tool in cassandra-env.sh (CASSANDRA-19416)
diff --git a/src/java/org/apache/cassandra/repair/consistent/LocalSessions.java
b/src/java/org/apache/cassandra/repair/consistent/LocalSessions.java
index cfb90ef04d..e61ad47003 100644
--- a/src/java/org/apache/cassandra/repair/consistent/LocalSessions.java
+++ b/src/java/org/apache/cassandra/repair/consistent/LocalSessions.java
@@ -322,7 +322,7 @@ public class LocalSessions
*/
public void cancelSession(UUID sessionID, boolean force)
{
- logger.info("Cancelling local repair session {}", sessionID);
+ logger.debug("Cancelling local repair session {}", sessionID);
LocalSession session = getSession(sessionID);
Preconditions.checkArgument(session != null, "Session {} does not
exist", sessionID);
Preconditions.checkArgument(force ||
session.coordinator.equals(getBroadcastAddressAndPort()),
@@ -397,7 +397,7 @@ public class LocalSessions
case FINALIZE_PROMISED:
continue;
default:
- logger.info("Found repair session {} with state = {} -
failing the repair", session.sessionID, session.getState());
+ logger.debug("Found repair session {} with state = {}
- failing the repair", session.sessionID, session.getState());
failSession(session, true);
}
}
@@ -453,12 +453,12 @@ public class LocalSessions
{
// if we delete a non-superseded session, some ranges
will be mis-reported as
// not having been repaired in repair_admin after a
restart
- logger.info("Skipping delete of FINALIZED LocalSession
{} because it has " +
+ logger.debug("Skipping delete of FINALIZED
LocalSession {} because it has " +
"not been superseded by a more recent
session", session.sessionID);
}
else if (!sessionHasData(session))
{
- logger.info("Auto deleting repair session {}",
session);
+ logger.debug("Auto deleting repair session {}",
session);
deleteSession(session.sessionID);
}
else
@@ -734,7 +734,7 @@ public class LocalSessions
}
else if (session.getState() != FAILED)
{
- logger.info("Failing local repair session {}",
session.sessionID);
+ logger.debug("Failing local repair session {}",
session.sessionID);
setStateAndSave(session, FAILED);
}
}
@@ -747,7 +747,7 @@ public class LocalSessions
public synchronized void deleteSession(UUID sessionID)
{
- logger.info("Deleting local repair session {}", sessionID);
+ logger.debug("Deleting local repair session {}", sessionID);
LocalSession session = getSession(sessionID);
Preconditions.checkArgument(session.isCompleted(), "Cannot delete
incomplete sessions");
@@ -817,7 +817,7 @@ public class LocalSessions
LocalSession session = createSessionUnsafe(sessionID, parentSession,
peers);
putSessionUnsafe(session);
- logger.info("Beginning local incremental repair session {}", session);
+ logger.debug("Beginning local incremental repair session {}", session);
ExecutorService executor =
Executors.newFixedThreadPool(parentSession.getColumnFamilyStores().size());
@@ -832,9 +832,9 @@ public class LocalSessions
{
try
{
- logger.info("Prepare phase for incremental repair session
{} completed", sessionID);
+ logger.debug("Prepare phase for incremental repair session
{} completed", sessionID);
if (!prepareSessionExceptFailed(session))
- logger.info("Session {} failed before anticompaction
completed", sessionID);
+ logger.debug("Session {} failed before anticompaction
completed", sessionID);
Message<PrepareConsistentResponse> message =
Message.out(PREPARE_CONSISTENT_RSP,
@@ -889,7 +889,7 @@ public class LocalSessions
LocalSession session = getSession(sessionID);
if (session != null && session.getState() != REPAIRING)
{
- logger.info("Setting local incremental repair session {} to
REPAIRING", session);
+ logger.debug("Setting local incremental repair session {} to
REPAIRING", session);
setStateAndSave(session, REPAIRING);
}
}
@@ -901,7 +901,7 @@ public class LocalSessions
LocalSession session = getSession(sessionID);
if (session == null)
{
- logger.info("Received FinalizePropose message for unknown repair
session {}, responding with failure", sessionID);
+ logger.debug("Received FinalizePropose message for unknown repair
session {}, responding with failure", sessionID);
sendMessage(from, Message.out(FAILED_SESSION_MSG, new
FailSession(sessionID)));
return;
}
@@ -920,7 +920,7 @@ public class LocalSessions
syncTable();
sendMessage(from, Message.out(FINALIZE_PROMISE_MSG, new
FinalizePromise(sessionID, getBroadcastAddressAndPort(), true)));
- logger.info("Received FinalizePropose message for incremental
repair session {}, responded with FinalizePromise", sessionID);
+ logger.debug("Received FinalizePropose message for incremental
repair session {}, responded with FinalizePromise", sessionID);
}
catch (IllegalArgumentException e)
{
@@ -961,7 +961,7 @@ public class LocalSessions
}
setStateAndSave(session, FINALIZED);
- logger.info("Finalized local repair session {}", sessionID);
+ logger.debug("Finalized local repair session {}", sessionID);
}
public void handleFailSessionMessage(InetAddressAndPort from, FailSession
msg)
@@ -972,7 +972,7 @@ public class LocalSessions
public void sendStatusRequest(LocalSession session)
{
- logger.info("Attempting to learn the outcome of unfinished local
incremental repair session {}", session.sessionID);
+ logger.debug("Attempting to learn the outcome of unfinished local
incremental repair session {}", session.sessionID);
Message<StatusRequest> request = Message.out(STATUS_REQ, new
StatusRequest(session.sessionID));
for (InetAddressAndPort participant : session.participants)
@@ -997,7 +997,7 @@ public class LocalSessions
else
{
sendMessage(from, Message.out(STATUS_RSP, new
StatusResponse(sessionID, session.getState())));
- logger.info("Responding to status response message for incremental
repair session {} with local state {}", sessionID, session.getState());
+ logger.debug("Responding to status response message for
incremental repair session {} with local state {}", sessionID,
session.getState());
}
}
@@ -1017,11 +1017,11 @@ public class LocalSessions
if (response.state == FINALIZED || response.state == FAILED)
{
setStateAndSave(session, response.state);
- logger.info("Unfinished local incremental repair session {} set to
state {}", sessionID, response.state);
+ logger.debug("Unfinished local incremental repair session {} set
to state {}", sessionID, response.state);
}
else
{
- logger.info("Received StatusResponse for repair session {} with
state {}, which is not actionable. Doing nothing.", sessionID, response.state);
+ logger.debug("Received StatusResponse for repair session {} with
state {}, which is not actionable. Doing nothing.", sessionID, response.state);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
